regex mismatch with package_name

[mpadge]

@xuanxu We had a recent glitch where this request let to these lines:

buffy/app/workers/ropensci/approved_package_worker.rb

Lines 30 to 32 in 20c5ac6

	def finalize_transfer
	org_team_name = "#{params.package_name}"
	org_team_name = "ropensci/#{org_team_name}" unless org_team_name.start_with?("ropensci/")

receiving a params.pkg_name value of partialling_out instead of partialling.out. The event_regex accepts the dot okay:

buffy/app/responders/ropensci/finalize_transfer_responder.rb

Line 8 in 20c5ac6

@event_regex = /\A@#{bot_name} (finalize|finalise) transfer of ([\/\w-]+)?\.?\s*\z/i

So I can't find where this might be going wrong? Any help would be appreciated! Ping @maelle

[xuanxu]

I think the command was not recognized because the event_regex didn't match. It only accepts the dot as a final character of the sentence, not as part of the name of the package:

finalize transfer of abcdef. will match the regex
finalize transfer of abc.def will not match the regex

This way finalize transfer of abcdef. will work and abcdef will be recognized as package name, not abcdef.

Should we update the regex to accept dots in the package name?, if so, anywhere in the name or except at the end? would partialling. be a valid name?

[maelle]

Should we update the regex to accept dots in the package name?, if so, anywhere in the name or except at the end? would partialling. be a valid name?

Yes please! The dots cannot be at the end.

The official documentation for R packages states

This should contain only (ASCII) letters, numbers and dot, have at least two characters and start with a letter and not end in a dot.