Skip to content

External service for approve responder isn't working #99

@mpadge

Description

@mpadge

We currently have our approve responder configured like this:

ropensci_approve:
only: editors
external_service:
name: badge
url: http://138.68.123.59:8000/badge
method: get
data_from_issue:
- repo
- repourl
- issue_id
template_file: approved.md
data_from_issue:
- reviewers-list
remove_labels:
- 5/awaiting-reviewer(s)-response
add_labels:
- 6/approved

The external service calls this plumber function which in turn calls roreviewapi::readme_badge(). That function should then confirm in the issue whether the repo has an rOpenSci badge in its README. That external call is, however, not made.

The external service in the welcome responder works:

welcome:
if:
value_matches:
submission-type: "Standard|Estándar|Stats"
message: "Thanks for submitting to rOpenSci, our editors and @ropensci-review-bot will reply soon. Type `@ropensci-review-bot help` for help."
external_service:
name: editorcheck
url: http://138.68.123.59:8000/editorcheck
method: get
data_from_issue:
- repo
- repourl
- issue_id
template_file: goodpractice.md

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions