Skip to content

Commit 0ac3ea1

Browse files
committed
update CRAN comments
1 parent ac8f15b commit 0ac3ea1

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

.Rbuildignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,5 @@ cran-comments.md
1717
^codecov\.yml$
1818
^RNeXML_.*\.tar\.gz$
1919
cache
20+
.circleci
21+

cran-comments.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
Dear CRAN maintainers,
22

3-
As requested by CRAN, this update addresses the occassional failing tests introduced by
4-
a recent release of taxize and crul packages.
3+
This update addresses several minor bugs in the handling of ploymorphic
4+
characters, as detailed in NEWS.md.
55

66
Cheers,
77

88
Carl
9+
10+
11+
## Test environments
12+
13+
* local OS X install, R 3.5.1
14+
* ubuntu 14.04 (on travis-ci), R 3.5.1
15+
* win-builder (devel and release)

tests/testthat/test_taxonomy.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ context("taxonomy")
44
data(bird.orders)
55
birdorders_small <- drop.tip(bird.orders, tip = 1:10)
66
birds <- add_trees(birdorders_small)
7-
birds <- taxize_nexml(birds, "NCBI")
87

98
data(chiroptera)
109
chiroptera_small <- drop.tip(chiroptera, tip = 1:906)
@@ -20,6 +19,7 @@ test_that("taxize_nexml correctly collects ncbi identifiers", {
2019

2120
testthat::skip_on_cran()
2221

22+
birds <- taxize_nexml(birds, "NCBI")
2323

2424
chir <- taxize_nexml(chir, "NCBI")
2525
chir_super_small <- taxize_nexml(chir_super_small, "NCBI")
@@ -43,8 +43,8 @@ test_that("taxize_nexml correctly collects ncbi identifiers", {
4343
})
4444

4545
test_that("we can extract taxonomy data from the object", {
46+
4647
expect_is(get_metadata(birds, "otus/otu"), "data.frame")
47-
4848
expect_is(get_metadata(chir_super_small, 'otus/otu'), "data.frame")
4949
})
5050

0 commit comments

Comments
 (0)