Skip to content

Conversation

@saikishor
Copy link
Member

Use the new API instead of get_lifecycle_state

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Dec 7, 2025
@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.94%. Comparing base (79f917e) to head (549fd10).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ory_controller/src/joint_trajectory_controller.cpp 0.00% 1 Missing and 1 partial ⚠️
...llers/src/motion_primitives_forward_controller.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
- Coverage   84.94%   84.94%   -0.01%     
==========================================
  Files         148      148              
  Lines       14425    14424       -1     
  Branches     1235     1236       +1     
==========================================
- Hits        12253    12252       -1     
  Misses       1742     1742              
  Partials      430      430              
Flag Coverage Δ
unittests 84.94% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ntroller/test/test_trajectory_controller_utils.hpp 84.79% <100.00%> (-0.05%) ⬇️
...llers/src/motion_primitives_forward_controller.cpp 32.25% <0.00%> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 83.88% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich merged commit 4a8192a into master Dec 7, 2025
12 of 17 checks passed
@christophfroehlich christophfroehlich deleted the change_to_get_lifecycle_id branch December 7, 2025 15:31
mergify bot pushed a commit that referenced this pull request Dec 7, 2025
mergify bot pushed a commit that referenced this pull request Dec 7, 2025
(cherry picked from commit 4a8192a)

# Conflicts:
#	motion_primitives_controllers/src/motion_primitives_forward_controller.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants