Changes Rack::File to Rack::Files #127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rack::Files was introduced in Rack 2.1
Owner
|
@aseroff Thank you for your PR. I can’t merge until we can show the tests are passing in CI. It looks like the Circle CI integration stopped working—I might want to have the project switched to Github Actions and to bump the supported Rails versions to 6 and 7. |
Owner
|
I’ve started a draft PR to set up CI. I could use help fixing failing tests. #128 |
Author
aseroff
changed the title
|
Any way we can get this working again? It's been 269 days since the last update and this is still a big problem. |
Author
Not up to me, unfortunately. I ended up just migrating to the Rails 8 PWA approach and removing this dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to work for me, and solves #126