refactor(sdk): tie SqlPackageVersion to DacFxVersion

- Move hardcoded DacFx version to Sdk.props
- Reference $(DacFxVersion) in DacpacTool.csproj
- Set SqlPackageVersion from DacFxVersion in Sdk.targets
- Ensures SDK owns versioning and keeps DacFx and SqlPackage in sync

Author: nmummau

src/DacpacTool/DacpacTool.csproj

@@ -12,7 +12,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.SqlServer.DacFx" Version="170.2.70" />
+    <PackageReference Include="Microsoft.SqlServer.DacFx" Version="$(DacFxVersion)" />
     <PackageReference Include="NuGet.Versioning" Version="6.14.0" />
     <PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
     <PackageReference Include="System.CommandLine.NamingConventionBinder" Version="2.0.0-beta4.22272.1" />

src/MSBuild.Sdk.SqlProj/Sdk/Sdk.props

@@ -10,6 +10,7 @@
     <MSBuildAllProjects Condition="'$(MSBuildToolsVersion)' != 'Current'">$(MSBuildAllProjects);$(MsBuildThisFileFullPath)</MSBuildAllProjects>
     <SqlServerVersion>Sql150</SqlServerVersion>
     <TargetExt>.dacpac</TargetExt>
+    <DacFxVersion>170.2.70</DacFxVersion>
   </PropertyGroup>
 
   <PropertyGroup>

src/MSBuild.Sdk.SqlProj/Sdk/Sdk.targets

@@ -321,8 +321,11 @@
     <ContainerImageName Condition="'$(ContainerImageName)'==''">$([System.String]::Copy('$(MSBuildProjectName)').ToLowerInvariant().Trim())-publisher</ContainerImageName>
     <ContainerImageTag Condition="'$(ContainerImageTag)'==''">$([System.String]::Copy('$(Configuration)').ToLowerInvariant().Trim())</ContainerImageTag>
 
-    <!-- Passed to the Dockerfile as build-arg SQLPACKAGE_VERSION -->
-    <SqlPackageVersion>170.2.70</SqlPackageVersion>
+    <!--
+      Passed to the Dockerfile as build-arg SQLPACKAGE_VERSION.
+      Using DacFxVersion which is set in Sdk.props so that we keep DacFx and SqlPackage in sync
+    -->
+    <SqlPackageVersion>$(DacFxVersion)</SqlPackageVersion>
 
     <!-- Local staging area for the project dacpac and referenced dacpacs -->
     <ContainerStagingDir>$(MSBuildProjectDirectory)\.container</ContainerStagingDir>