From 600654dfb5965b3a7a6d832f362c1f0398e66b8e Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Mon, 5 May 2025 16:40:56 +0200 Subject: [PATCH 1/3] Fix "ambiguous first argument" warning in test suite ``` test/fiddle/test_pointer.rb:288: warning: ambiguous first argument; put parentheses or a space even after '-' operator ``` --- test/fiddle/test_pointer.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fiddle/test_pointer.rb b/test/fiddle/test_pointer.rb index 54953bcd..f799f6f3 100644 --- a/test/fiddle/test_pointer.rb +++ b/test/fiddle/test_pointer.rb @@ -285,7 +285,7 @@ def test_size end assert_equal 0, Pointer.new(0).size assert_equal 0, Pointer.new(0).ref.size - assert_equal -1, (Pointer.new(0) + 1).size + assert_equal(-1, (Pointer.new(0) + 1).size) end def test_size= From 4055ae04b83d98f5a369924c1a49bf9dc0a8718a Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Tue, 6 May 2025 14:48:35 +0900 Subject: [PATCH 2/3] Add (...) --- test/fiddle/test_pointer.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/fiddle/test_pointer.rb b/test/fiddle/test_pointer.rb index f799f6f3..ede22142 100644 --- a/test/fiddle/test_pointer.rb +++ b/test/fiddle/test_pointer.rb @@ -283,8 +283,8 @@ def test_size Pointer.malloc(4, Fiddle::RUBY_FREE) do |ptr| assert_equal 4, ptr.size end - assert_equal 0, Pointer.new(0).size - assert_equal 0, Pointer.new(0).ref.size + assert_equal(0, Pointer.new(0).size) + assert_equal(0, Pointer.new(0).ref.size) assert_equal(-1, (Pointer.new(0) + 1).size) end From e387259c5492c79f6b0423fe8cb8c358a3a6f8e2 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Tue, 6 May 2025 14:49:00 +0900 Subject: [PATCH 3/3] Add (...) --- test/fiddle/test_pointer.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fiddle/test_pointer.rb b/test/fiddle/test_pointer.rb index ede22142..1c7bc15c 100644 --- a/test/fiddle/test_pointer.rb +++ b/test/fiddle/test_pointer.rb @@ -281,7 +281,7 @@ def test_null? def test_size Pointer.malloc(4, Fiddle::RUBY_FREE) do |ptr| - assert_equal 4, ptr.size + assert_equal(4, ptr.size) end assert_equal(0, Pointer.new(0).size) assert_equal(0, Pointer.new(0).ref.size)