Fixed problem when entering one million items for donation (#5155)

Author: GiovannyCordeiro

app/javascript/utils/donations.js

@@ -108,13 +108,14 @@ $(function() {
   )
 
   const large_donation_boundary = 100000;
-  $(document).on("submit", "form#new_donation", (e, _) =>
+  $(document).on("click", "form#new_donation button[type='submit']", (e, _) =>
     $(".quantity").each(function(_, q) {
       const quantity = parseInt(q.value, 10);
       if (quantity > large_donation_boundary) {
-        confirm(
+        const answer_confirm = confirm(
           `${quantity} items is a large donation! Are you sure you want to submit?`
-        );
+        )
+        answer_confirm === false && e.preventDefault();
       }
     })
   );

spec/system/donation_system_spec.rb

@@ -431,6 +431,20 @@
           end.to change { Donation.count }.by(1)
         end
 
+        it "Remains on the page when the user cancels a large donation", js: true do
+          select Donation::SOURCES[:misc], from: "donation_source"
+          select StorageLocation.first.name, from: "donation_storage_location_id"
+          select Item.alphabetized.first.name, from: "donation_line_items_attributes_0_item_id"
+          fill_in "donation_line_items_attributes_0_quantity", with: "1000000"
+
+          dismiss_confirm do
+            click_button "Save"
+          end
+
+          expect(page).to have_current_path(new_donation_path)
+          expect(page).to have_button("Save")
+        end
+
         it "Requires quantity to be numeric" do
           select Donation::SOURCES[:misc], from: "donation_source"
           select StorageLocation.first.name, from: "donation_storage_location_id"