fix: set table type to external for glue (#6386)

# Description

- Set table type as external for Glue tables

## Linear Ticket

- Resolves WAR-1177

## Security

- [x] The code changed/added as part of this pull request won't create
any security issues with how the software is being used.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Ensure AWS Glue tables are created and updated as EXTERNAL_TABLE, with
tests asserting the table type.
> 
> - **Glue schema repository**:
> - Set `TableType` to `EXTERNAL_TABLE` in `CreateTable` and
`updateTable`.
> - **Tests**:
>   - Assert created table `TableType` is `EXTERNAL_TABLE`.
>   - Add missing `require.NoError` after `AddColumns`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
e00eb99. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: achettyiitr

warehouse/integrations/datalake/schema-repository/glue.go

@@ -16,6 +16,7 @@ import (
 	"github.com/rudderlabs/rudder-go-kit/logger"
 	"github.com/rudderlabs/rudder-go-kit/stats"
 	obskit "github.com/rudderlabs/rudder-observability-kit/go/labels"
+
 	utils "github.com/rudderlabs/rudder-server/utils/awsutils"
 	"github.com/rudderlabs/rudder-server/warehouse/internal/model"
 	"github.com/rudderlabs/rudder-server/warehouse/logfield"
@@ -93,6 +94,7 @@ func (g *GlueSchemaRepository) CreateTable(ctx context.Context, tableName string
 	tableInput := &types.TableInput{
 		Name:          aws.String(tableName),
 		PartitionKeys: partitionKeys,
+		TableType:     aws.String("EXTERNAL_TABLE"),
 	}
 
 	// create table request
@@ -271,7 +273,8 @@ func (g *GlueSchemaRepository) updateTable(ctx context.Context, tableName string
 	glueInput := &glue.UpdateTableInput{
 		DatabaseName: aws.String(g.Namespace),
 		TableInput: &types.TableInput{
-			Name: aws.String(tableName),
+			Name:      aws.String(tableName),
+			TableType: aws.String("EXTERNAL_TABLE"),
 		},
 	}
 

warehouse/integrations/datalake/schema-repository/glue_test.go

@@ -142,6 +142,14 @@ func TestGlueSchemaRepositoryRoundTrip(t *testing.T) {
 			err = g.CreateTable(ctx, testTable, testColumns)
 			require.NoError(t, err)
 
+			tableOutput, err := g.GlueClient.GetTable(ctx, &glue.GetTableInput{
+				Name:         &testTable,
+				DatabaseName: &testNamespace,
+			})
+			require.NoError(t, err)
+			require.NotNil(t, tableOutput.Table)
+			require.Equal(t, "EXTERNAL_TABLE", *tableOutput.Table.TableType)
+
 			t.Log("Creating already existing table should not fail")
 			err = g.CreateTable(ctx, testTable, testColumns)
 			require.NoError(t, err)
@@ -154,6 +162,7 @@ func TestGlueSchemaRepositoryRoundTrip(t *testing.T) {
 				{Name: "alter_test_float", Type: "float"},
 				{Name: "alter_test_datetime", Type: "datetime"},
 			})
+			require.NoError(t, err)
 
 			t.Log("Preparing load files metadata")
 			f, err := os.Open(testFile)