chore: cleanup lingering temporary export files upon suppression backup service startup (#6493)

🔒 Scanned for secrets using gitleaks 8.28.0

# Description

If suppression backup service terminates abruptly it leaves behind
temporary export files which are big in size. Now we are deleting any
lingering temporary export files during startup

## Linear Ticket

resolves PIPE-2480

## Security

- [x] The code changed/added as part of this pull request won't create
any security issues with how the software is being used.

Author: atzoum

admin/admin.go

@@ -107,7 +107,7 @@ func (*Admin) GetLoggingConfig(_ struct{}, reply *string) (err error) {
 
 // StartServer starts an HTTP server listening on unix socket and serving rpc communication
 func StartServer(ctx context.Context) error {
-	tmpDirPath, err := misc.CreateTMPDIR()
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		panic(err)
 	}

archiver/worker.go

@@ -147,7 +147,7 @@ func (w *worker) uploadJobs(ctx context.Context, jobs []*jobsdb.JobT) (string, e
 	workspaceID := jobs[0].WorkspaceId
 
 	filePath := path.Join(
-		lo.Must(misc.CreateTMPDIR()),
+		lo.Must(misc.GetTmpDir()),
 		"rudder-backups",
 		w.sourceID,
 		fmt.Sprintf("%d_%d_%s_%s.json.gz", firstJobCreatedAt.Unix(), lastJobCreatedAt.Unix(), workspaceID, uuid.NewString()),

enterprise/reporting/error_index/worker.go

@@ -214,7 +214,7 @@ func (w *worker) uploadPayloads(ctx context.Context, payloads []payload) (*filem
 		return i.FailedAtTime().Compare(j.FailedAtTime())
 	})
 
-	tmpDirPath, err := misc.CreateTMPDIR()
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		return nil, fmt.Errorf("creating tmp directory: %w", err)
 	}

enterprise/reporting/event_sampler/badger_event_sampler.go

@@ -38,7 +38,7 @@ func GetPathName(module string) string {
 }
 
 func DefaultPath(pathName string) (string, error) {
-	tmpDirPath, err := misc.CreateTMPDIR()
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		return "", err
 	}

enterprise/suppress-user/factory.go

@@ -216,7 +216,7 @@ func (m *Factory) newSyncerWithBadgerRepo(repoPath string, seederSource func() (
 }
 
 func getRepoPath() (fullSuppressionPath, latestSuppressionPath string, err error) {
-	tmpDir, err := misc.CreateTMPDIR()
+	tmpDir, err := misc.GetTmpDir()
 	if err != nil {
 		return "", "", fmt.Errorf("could not create tmp dir: %w", err)
 	}

router/batchrouter/asyncdestinationmanager/bing-ads/audience/util.go

@@ -39,7 +39,7 @@ contains the template of the uploadable file.
 */
 func createActionFile(audienceId, actionType string) (*ActionFileInfo, error) {
 	localTmpDirName := fmt.Sprintf(`/%s/`, misc.RudderAsyncDestinationLogs)
-	tmpDirPath, err := misc.CreateTMPDIR()
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		return nil, err
 	}

router/batchrouter/asyncdestinationmanager/bing-ads/offline-conversions/util.go

@@ -61,7 +61,7 @@ contains the template of the uploadable file.
 */
 func createActionFile(actionType string) (*ActionFileInfo, error) {
 	localTmpDirName := fmt.Sprintf(`/%s/`, misc.RudderAsyncDestinationLogs)
-	tmpDirPath, err := misc.CreateTMPDIR()
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		return nil, err
 	}
@@ -251,7 +251,7 @@ func (b *BingAdsBulkUploader) downloadAndGetUploadStatusFile(ResultFileUrl strin
 		panic(fmt.Errorf("BRT: Failed saving zip file. Err: %w", err))
 	}
 	localTmpDirName := fmt.Sprintf(`/%s/`, misc.RudderAsyncDestinationLogs)
-	tmpDirPath, err := misc.CreateTMPDIR()
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		panic(fmt.Errorf("error while creating tmp directory: %w", err))
 	}

router/batchrouter/asyncdestinationmanager/eloqua/utils.go

@@ -61,7 +61,7 @@ func createCSVFile(fields []string, file *os.File, uploadJobInfo *JobInfo, jobId
 	scanner := bufio.NewScanner(file)
 	scanner.Buffer(nil, bufferSize)
 	localTmpDirName := fmt.Sprintf(`/%s/`, misc.RudderAsyncDestinationLogs)
-	tmpDirPath, err := misc.CreateTMPDIR()
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		return "", 0, err
 	}

router/batchrouter/asyncdestinationmanager/lytics_bulk_upload/utils.go

@@ -115,8 +115,8 @@ func createCSVWriter(fileName string) (*ActionFileInfo, error) {
 }
 
 func (u *LyticsBulkUploader) createCSVFile(existingFilePath string, streamTraitsMapping []StreamTraitMapping) (*ActionFileInfo, error) {
-	// Create a temporary directory using misc.CreateTMPDIR
-	tmpDirPath, err := misc.CreateTMPDIR()
+	// Create a temporary directory using misc.GetTmpDir
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		return nil, fmt.Errorf("failed to create temporary directory: %v", err)
 	}

router/batchrouter/asyncdestinationmanager/sftp/utils.go

@@ -200,7 +200,7 @@ func generateCSVFile(filePath string, sortColumnNames bool) (string, error) {
 
 func getTempFilePath() (string, error) {
 	localTmpDirName := fmt.Sprintf(`/%s/`, misc.RudderAsyncDestinationLogs)
-	tmpDirPath, err := misc.CreateTMPDIR()
+	tmpDirPath, err := misc.GetTmpDir()
 	if err != nil {
 		return "", err
 	}