git2::IndexTime is not ready for year 2038

[samvv]

Trying to construct a git2::IndexTime, I noticed that the signature of new is not year 2038 compatible.

pub fn new(seconds: i32, nanoseconds: u32) -> IndexTime

The function takes a signed 32-bit integer, which will overlow somewhere in 2038.

More information at https://theyear2038problem.com/

I see that the issue seems to be fixed in master but not yet published. I'll close this issue if the new version gets published.

[ehuss]

I'm not sure what being fixed in master might be referring to. I don't think that code has changed.

It looks like this might be an upstream issue, as git_index_time appears to still be an unsigned integer. Would you mind reporting this at https://github.com/libgit2/libgit2/issues instead?

[samvv]

Ah then I misread some source code. Will do, hopefully tomorrow. If there's no update don't hesitate to ping.

[samvv]

Not sure but this is an excerpt from master right here:

pub fn new(time: i64, offset: i32) -> Time {

Notice the i64 that is (presumably) the amount of seconds since epoch. No i32. This is good.

Also, the git_time_t in the sys crate on master make use of i64:

pub type git_time_t = i64;

I believe there's no need to escalate, even more so because this pull request seems to have fixed the issue in libgit2 itself many years ago. This seems to be a packaging issue AFAICT.

[ehuss]

Index times are stored in 32-bits in git (see index-format). The issue is that libgit2 is using a signed 32-bit integer (here). That should probably be unsigned. Otherwise there is not much that can be done since that is the on-disk format.