cleanup simd constant transmute => new

Author: RagnarGrootKoerkamp

src/collect.rs

@@ -151,7 +151,7 @@ impl<I: ChunkIt<u32x8>> CollectAndDedup for PaddedIt<I> {
                 let len = it.len();
                 let lane_offsets: [u32x8; 8] = from_fn(|i| u32x8::splat((i * len) as u32));
                 let offsets: [u32; 8] = from_fn(|i| i as u32);
-                let mut offsets: u32x8 = unsafe { transmute(offsets) };
+                let mut offsets: u32x8 = S::new(offsets);
 
                 let mut mask = u32x8::ZERO;
                 let mut padding_i = 0;

src/intrinsics/dedup.rs

@@ -4,9 +4,9 @@ use core::mem::transmute;
 use packed_seq::L;
 
 #[cfg(target_feature = "neon")]
-const OFFSET: S = unsafe { std::mem::transmute([0x03_02_01_00; 8]) };
+const OFFSET: S = S::new([0x03_02_01_00; 8]);
 #[cfg(target_feature = "neon")]
-const MASK: S = unsafe { std::mem::transmute([0x04_04_04_04; 8]) };
+const MASK: S = S::new([0x04_04_04_04; 8]);
 
 /// Dedup adjacent `new` values (starting with the last element of `old`).
 /// If an element is different from the preceding element, append the corresponding element of `vals` to `v[write_idx]`.

src/minimizers.rs

@@ -16,7 +16,7 @@ use seq_hash::KmerHasher;
 use wide::u32x8;
 
 pub const SKIPPED: u32 = u32::MAX - 1;
-pub(crate) const SIMD_SKIPPED: u32x8 = unsafe { std::mem::transmute([SKIPPED; 8]) };
+pub(crate) const SIMD_SKIPPED: u32x8 = u32x8::new([SKIPPED; 8]);
 
 /// Minimizer position of a single window.
 pub fn one_minimizer<'s>(seq: impl Seq<'s>, hasher: &impl KmerHasher) -> usize {