TASK: Fix PHP 8.4 deprecations (#247)

Author: sabbelasichon

.github/workflows/php_linter.yaml

@@ -15,7 +15,7 @@ jobs:
         runs-on: ubuntu-latest
         strategy:
             matrix:
-                php-versions: [ 8.1, 8.2, 8.3 ]
+                php-versions: [ 8.1, 8.2, 8.3, 8.4 ]
         steps:
             -   uses: actions/checkout@v4
 

.github/workflows/weekly_pull_requests.yaml

@@ -33,7 +33,7 @@ jobs:
             -
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: 7.4
+                    php-version: 8.1
                     coverage: none
 
             -   uses: "ramsey/composer-install@v3"

Classes/Asset/EntrypointLookupCollection.php

@@ -26,7 +26,7 @@ public function __construct(
     ) {
     }
 
-    public function getEntrypointLookup(string $buildName = null): EntrypointLookupInterface
+    public function getEntrypointLookup(?string $buildName = null): EntrypointLookupInterface
     {
         if ($this->buildEntrypoints === null) {
             $this->buildEntrypoints = $this->entryLookupFactory->getCollection();

Classes/Asset/EntrypointLookupCollectionInterface.php

@@ -13,5 +13,5 @@
 
 interface EntrypointLookupCollectionInterface
 {
-    public function getEntrypointLookup(string $buildName = null): EntrypointLookupInterface;
+    public function getEntrypointLookup(?string $buildName = null): EntrypointLookupInterface;
 }

Classes/Form/FormDataProvider/RichtextEncoreConfiguration.php

@@ -21,7 +21,7 @@ final class RichtextEncoreConfiguration implements FormDataProviderInterface
 {
     private readonly EntrypointLookupCollectionInterface $entrypointLookupCollection;
 
-    public function __construct(EntrypointLookupCollectionInterface $entrypointLookupCollection = null)
+    public function __construct(?EntrypointLookupCollectionInterface $entrypointLookupCollection = null)
     {
         $this->entrypointLookupCollection = $entrypointLookupCollection ?? GeneralUtility::makeInstance(
             EntrypointLookupCollection::class

Classes/ViewHelpers/Stimulus/AbstractViewHelper.php

@@ -65,8 +65,8 @@ public function renderStimulusController(
      */
     public function renderStimulusAction(
         $controllerName,
-        string $actionName = null,
-        string $eventName = null,
+        ?string $actionName = null,
+        ?string $eventName = null,
         array $parameters = []
     ): StimulusActionsDto {
         $dto = new StimulusActionsDto();
@@ -133,7 +133,7 @@ public function appendStimulusAction(
         StimulusActionsDto $dto,
         string $controllerName,
         string $actionName,
-        string $eventName = null,
+        ?string $eventName = null,
         array $parameters = []
     ): StimulusActionsDto {
         $dto->addAction($controllerName, $actionName, $eventName, $parameters);
@@ -145,7 +145,7 @@ public function appendStimulusAction(
      * @param string|array $controllerName the Stimulus controller name
      * @param string|null $targetNames The space-separated list of target names if a string is passed to the 1st argument. Optional.
      */
-    public function renderStimulusTarget($controllerName, string $targetNames = null): StimulusTargetsDto
+    public function renderStimulusTarget($controllerName, ?string $targetNames = null): StimulusTargetsDto
     {
         $dto = new StimulusTargetsDto();
         if (\is_array($controllerName)) {
@@ -183,7 +183,7 @@ public function renderStimulusTarget($controllerName, string $targetNames = null
     public function appendStimulusTarget(
         StimulusTargetsDto $dto,
         string $controllerName,
-        string $targetNames = null
+        ?string $targetNames = null
     ): StimulusTargetsDto {
         $dto->addTarget($controllerName, $targetNames);
 

Classes/ViewHelpers/Stimulus/Dto/StimulusActionsDto.php

@@ -40,7 +40,7 @@ public function __toString(): string
     public function addAction(
         string $controllerName,
         string $actionName,
-        string $eventName = null,
+        ?string $eventName = null,
         array $parameters = []
     ): void {
         $controllerName = $this->getFormattedControllerName($controllerName);

Classes/ViewHelpers/Stimulus/Dto/StimulusTargetsDto.php

@@ -33,7 +33,7 @@ public function __toString(): string
      * @param string      $controllerName the Stimulus controller name
      * @param string|null $targetNames    The space-separated list of target names if a string is passed to the 1st argument. Optional.
      */
-    public function addTarget(string $controllerName, string $targetNames = null): void
+    public function addTarget(string $controllerName, ?string $targetNames = null): void
     {
         $controllerName = $this->getFormattedControllerName($controllerName);
 

Tests/Unit/Form/FormDataProvider/RichtextEncoreConfigurationTest.php

@@ -90,7 +90,7 @@ public static function provideRteConfigurationWithEncoreFiles(): Iterator
     private function createEntrypointLookUpCollection(): EntrypointLookupCollectionInterface
     {
         return new class() implements EntrypointLookupCollectionInterface {
-            public function getEntrypointLookup(string $buildName = null): EntrypointLookupInterface
+            public function getEntrypointLookup(?string $buildName = null): EntrypointLookupInterface
             {
                 if ($buildName !== '_default') {
                     throw new Exception('Invalid buildName in test case', 1_645_708_934);