Apply copilot suggestions

Author: ariostas

src/skhep_testdata/local_files.py

@@ -26,7 +26,9 @@ def data_path(
     filename: str, raise_missing: bool = True, cache_dir: str | None = None
 ) -> str:
     if remote_files.is_known_remote(filename):
-        return remote_files.remote_file(filename, raise_missing=raise_missing)
+        return remote_files.remote_file(
+            filename, cache_dir=cache_dir, raise_missing=raise_missing
+        )
 
     if filename not in known_files and raise_missing:
         raise FileNotFoundError(filename)

src/skhep_testdata/remote_files.py

@@ -72,9 +72,9 @@ def fetch_remote_dataset(
     logging.warning("Downloading %s", url)
     urlretrieve(url, str(writefile))
 
-    if tarfile.is_tarfile(writefile):
+    if tarfile.is_tarfile(str(writefile)):
         logging.warning("Extracting %s", writefile)
-        with tarfile.open(writefile) as tar:
+        with tarfile.open(str(writefile)) as tar:
             members = [tar.getmember(f) for f in files.values()]
             tar.extractall(str(dataset_dir), members)
 

tests/test_local_files.py

@@ -32,10 +32,10 @@ def test_data_path_cached():
 
 
 def test_delegate_to_remote(monkeypatch, tmpdir):
-    def dummy_remote_file(filename, data_dir=None, raise_missing=False):
-        if not data_dir:
-            data_dir = str(tmpdir)
-        return str(Path(data_dir) / filename)
+    def dummy_remote_file(filename, cache_dir=None, raise_missing=False):
+        if not cache_dir:
+            cache_dir = str(tmpdir)
+        return str(Path(cache_dir) / filename)
 
     monkeypatch.setattr(skhtd.remote_files, "remote_file", dummy_remote_file)
     monkeypatch.setattr(skhtd.remote_files, "is_known_remote", lambda _: True)