Commit 5d1cc26
committed
Move hexDecode test helper into a test file
The inclusion of the test helper outside of a _test.go file results
in any downstream consumer of this library, either directly or
transitively, having the testing package reachable in their binaries.
See the following dependency tree for an example which shows how
`testing` ends up being included in `github.com/sigstore/sigstore-go`.
```bash
goda tree "reach(github.com/sigstore/sigstore-go/pkg/tlog...:all, testing)"
├ github.com/sigstore/sigstore-go/pkg/tlog
├ github.com/sigstore/rekor/pkg/types/dsse/v0.0.1
└ github.com/in-toto/in-toto-golang/in_toto
└ github.com/secure-systems-lab/go-securesystemslib/signerverifier
└ github.com/sigstore/rekor/pkg/types/intoto/v0.0.2
└ github.com/in-toto/in-toto-golang/in_toto ~
```
Since the hexDecode helper was only being consumed in tests it was
relocated from signerverifier/utils.go to signerverifier/utils_test.go.1 parent ebae973 commit 5d1cc26
2 files changed
+10
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| |||
141 | 140 | | |
142 | 141 | | |
143 | 142 | | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
11 | 21 | | |
12 | 22 | | |
13 | 23 | | |
| |||
0 commit comments