cleanup

Author: bsneed

Sources/AnalyticsLive/Signals/Context.swift

@@ -22,7 +22,7 @@ public struct StaticContext: Codable {
 
     let app: Application
     let library: Library
-    let signalsRuntime: String
+    let signalsRuntime: String?
 
     private static var _signalsRuntimeVersion: String? = nil
 
@@ -48,13 +48,14 @@ public struct StaticContext: Codable {
         return StaticContext(
             app: application,
             library: library,
-            signalsRuntime: _signalsRuntimeVersion ?? SignalsRuntime.version
+            signalsRuntime: _signalsRuntimeVersion
         )
     }()
 
-    static func configureRuntimeVersion(engine: JSEngine) {
+    static func configureRuntimeVersion(engine: JSEngine?) {
         guard _signalsRuntimeVersion == nil else { return }
-        let jsVersion = /*engine.value(for: "SEGMENT_SIGNALS_RUNTIME_VERSION") as? String// ??*/ SignalsRuntime.version
+        guard let engine else { return }
+        let jsVersion = engine.value(for: "SEGMENT_SIGNALS_RUNTIME_VERSION")?.typed(as: String.self)
         _signalsRuntimeVersion = jsVersion
     }
 }

Sources/AnalyticsLive/Signals/Runtime/SignalsJS.swift

@@ -181,9 +181,6 @@ public class Signals: Plugin {
 extension Signals: LivePluginsDependent {
     public func prepare(engine: JSEngine) {
         self.engine = engine
-
-        //engine.evaluate(script: SignalsRuntime.embeddedJS, evaluator: "Signals.prepare")
-        StaticContext.configureRuntimeVersion(engine: engine)
     }
 
     public func readyToStart() {
@@ -267,6 +264,7 @@ extension Signals {
     internal func updateConfiguration() {
         // Update JS configuration
         signalObject?.setValue(configuration.maximumBufferSize, for: "maxBufferSize")
+        StaticContext.configureRuntimeVersion(engine: engine)
 
         // Update native configuration
         broadcasters = configuration.broadcasters