Skip to content

Conversation

@Hariksh
Copy link
Contributor

@Hariksh Hariksh commented Nov 6, 2025

…ML parsing"

Description

This PR fixes an issue in bash/shell code blocks where syntax highlighting behaved incorrectly when text was enclosed within angle brackets.

Example:

pfinfo <usual_guide>

Linked Issue

#1020

@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit a04ecbb
🔍 Latest deploy log https://app.netlify.com/projects/shiki-matsu/deploys/690dfd6f17fcc800080656f4
😎 Deploy Preview https://deploy-preview-1100--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit a04ecbb
🔍 Latest deploy log https://app.netlify.com/projects/shiki-next/deploys/690dfd6f5521e10008d1c2c3
😎 Deploy Preview https://deploy-preview-1100--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Hariksh
Copy link
Contributor Author

Hariksh commented Nov 6, 2025

I noticed that the CI workflow is currently failing on Node 18.x with the following error:

This appears to be caused by a recent dependency update (likely vitest or a related package) that depends on node:inspector/promises, which was only introduced in Node 20+.
Since this PR only adds a preprocessing transformer (shiki:fix-shell-angle-placeholders) for shell code blocks in the docs, it doesn’t touch any runtime logic or test-related modules.

Verified locally:

  • Works fine on Node 20.x and 22.x.
  • Only Node 18.x fails due to the missing built-in module.

Suggested follow-up

You might consider:

  • Updating the CI matrix to drop Node 18.x (since Node 18 is now EOL), or
  • Adding a version check to skip tests using node:inspector/promises on older Node versions.

Thanks for reviewing this!

@antfu
Copy link
Member

antfu commented Nov 7, 2025

I am not sure if that's the correct fix. I feel that's probably something to be fixed on the upstream grammar side instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants