Skip to content

Conversation

@mahi656
Copy link

@mahi656 mahi656 commented Nov 9, 2025

Problem

  • Shell script syntax highlighting was incorrect when unquoted arguments contained angle brackets (e.g., pfinfo <file>).

  • The root cause was that the argument_context entry in the shellscript grammar did not include a name property.

  • Without this property, the highlighter could not assign the correct scope, causing incorrect or inconsistent token highlighting.

This issue is tracked in #1020.

  • Fix

  • The missing name property was added to argument_context, allowing unquoted arguments to be correctly scoped as string.unquoted.argument.shell.

Result

    • Angle bracket arguments are now highlighted correctly
    • Highlighting behavior is consistent across themes
    • Shell script grammar behaves as expected

Fixes #1020

@netlify
Copy link

netlify bot commented Nov 9, 2025

Deploy Preview for shiki-next ready!

Name Link
🔨 Latest commit 441aceb
🔍 Latest deploy log https://app.netlify.com/projects/shiki-next/deploys/69104525a5e3720008f9be9b
😎 Deploy Preview https://deploy-preview-1115--shiki-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 9, 2025

Deploy Preview for shiki-matsu ready!

Name Link
🔨 Latest commit 441aceb
🔍 Latest deploy log https://app.netlify.com/projects/shiki-matsu/deploys/69104525755ed6000800c1ee
😎 Deploy Preview https://deploy-preview-1115--shiki-matsu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text highlighting issue between angle brackets

1 participant