fix(transformers): handle multi-token comments in rose-pine theme #1118
+347
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes shikijs#1083 The rose-pine theme tokenizes comments like '// [!code --]' into multiple tokens ('//' and ' [!code --]'), while other themes like dracula keep them as a single token. This caused transformers to fail to recognize the comment notation. Changes: - Enhanced parseComments() to detect and handle multi-token comments - Added logic to combine adjacent comment tokens when processing - Updated notation transformer to properly handle additional tokens - Added comprehensive tests for both single and multi-token scenarios The fix maintains backward compatibility with existing themes while enabling transformers to work correctly with themes that split comments.
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
+ Coverage 88.35% 88.46% +0.10%
==========================================
Files 74 74
Lines 3322 3345 +23
Branches 956 965 +9
==========================================
+ Hits 2935 2959 +24
+ Misses 344 342 -2
- Partials 43 44 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Remove Node.js 18.x from CI matrix (requires Node.js >= 19 for coverage) - Add JSX parsing and v1 algorithm test cases to improve coverage
- Add parse-comments-multi-token.test.ts to directly test the new multi-token handling code - This covers the specific code paths added for rose-pine theme compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The rose-pine theme tokenizes comments like
// [!code --]into multiple tokens ('//'and' [!code --]'), while other themes like dracula keep them as a single token.This caused transformers to fail to recognize the comment notation.
Changes:
parseComments()to detect and handle multi-token comments✅ The fix maintains backward compatibility with existing themes while enabling transformers to work correctly with themes that split comments.
🔗 Linked Issues
Fixes #1083
💬 Additional Context
Is there anything you'd like reviewers to focus on?