Skip to content

Commit c3b9e82

Browse files
Don't pass non-owned relay_port_factory
1 parent d761c49 commit c3b9e82

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

p2p/client/basic_port_allocator.cc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,8 @@ BasicPortAllocator::CreateIceGatherer(const std::string& name) {
246246
CheckRunOnValidThreadAndInitialized();
247247
// We follow the order that PeerConnectionFactory::CreatePeerConnection
248248
// + PeerConnection::InitializePortAllocator_n does:
249-
// 1. Create with NetworkManager, PacketSocketFactory, and RelayPortFactory.
249+
// 1. Create with NetworkManager and PacketSocketFactory (relay port factory
250+
// has mismatched ownership, and we are not overriding it anyway).
250251
// 2. SetNetworkIgnoreMask().
251252
// 3. Initialize()
252253
// 4. User setters to set flags and other settings
@@ -263,7 +264,7 @@ BasicPortAllocator::CreateIceGatherer(const std::string& name) {
263264
network_manager(),
264265
socket_factory_,
265266
nullptr,
266-
relay_port_factory_.get());
267+
nullptr);
267268

268269
// 2. SetNetworkIgnoreMask().
269270
new_allocator->SetNetworkIgnoreMask(network_ignore_mask_);

0 commit comments

Comments
 (0)