Skip to content

Commit e9aaf50

Browse files
committed
Revert "Use Siso in iOS/Android build scripts"
This reverts commit 5d165b1. Reason: To get iOS builds working again, don't use siso yet.
1 parent bb6726c commit e9aaf50

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

tools_webrtc/android/build_aar.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,8 @@ def _RunGN(args):
118118

119119
def _RunNinja(output_directory, args):
120120
cmd = [
121-
os.path.join(SRC_DIR, 'third_party', 'siso', 'cipd', 'siso'),
122-
'ninja',
123-
'-C',
124-
output_directory,
121+
os.path.join(SRC_DIR, 'third_party', 'ninja', 'ninja'), '-C',
122+
output_directory
125123
]
126124
cmd.extend(args)
127125
logging.debug('Running: %r', cmd)
@@ -177,14 +175,9 @@ def Build(build_dir, arch, use_remoteexec, extra_gn_args, extra_gn_switches,
177175
'is_component_build': False,
178176
'rtc_include_tests': False,
179177
'target_cpu': _GetTargetCpu(arch),
178+
'use_remoteexec': use_remoteexec,
180179
'android_static_analysis': "off",
181-
'use_siso': True,
182180
}
183-
if use_remoteexec:
184-
gn_args.update({
185-
'use_remoteexec': True,
186-
'use_reclient': False,
187-
})
188181
arm_version = _GetArmVersion(arch)
189182
if arm_version:
190183
gn_args['arm_version'] = arm_version
@@ -198,7 +191,7 @@ def Build(build_dir, arch, use_remoteexec, extra_gn_args, extra_gn_switches,
198191

199192
ninja_args = TARGETS[:]
200193
if use_remoteexec:
201-
ninja_args.extend(['-remote_jobs', '200'])
194+
ninja_args.extend(['-j', '200'])
202195
ninja_args.extend(extra_ninja_switches)
203196
_RunNinja(output_directory, ninja_args)
204197

tools_webrtc/ios/build_ios_libs.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -190,13 +190,8 @@ def BuildWebRTC(output_dir, target_environment, target_arch, flavor,
190190
('true' if libvpx_build_vp9 else 'false'))
191191

192192
gn_args.append('use_lld=true')
193+
gn_args.append('use_remoteexec=' + ('true' if use_remoteexec else 'false'))
193194
gn_args.append('rtc_enable_objc_symbol_export=true')
194-
gn_args.append('use_siso=true')
195-
if use_remoteexec:
196-
gn_args.extend([
197-
'use_remoteexec=true',
198-
'use_reclient=false',
199-
])
200195

201196
args_string = ' '.join(gn_args + extra_gn_args)
202197
logging.info('Building WebRTC with args: %s', args_string)
@@ -212,14 +207,13 @@ def BuildWebRTC(output_dir, target_environment, target_arch, flavor,
212207
logging.info('Building target: %s', gn_target_name)
213208

214209
cmd = [
215-
os.path.join(SRC_DIR, 'third_party', 'siso', 'cipd', 'siso'),
216-
'ninja',
210+
os.path.join(SRC_DIR, 'third_party', 'ninja', 'ninja'),
217211
'-C',
218212
output_dir,
219213
gn_target_name,
220214
]
221215
if use_remoteexec:
222-
cmd.extend(['-remote_jobs', '200'])
216+
cmd.extend(['-j', '200'])
223217
_RunCommand(cmd)
224218

225219

0 commit comments

Comments
 (0)