Skip to content

Remove SimpleCov from conformance test entrypoints #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2025
Merged

Remove SimpleCov from conformance test entrypoints #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c2da1f
Remove SimpleCov from conformance test entrypoints
landongrindheim Oct 23, 2025
93e0cce
Remove Codecov upload steps from conformance tests
landongrindheim Oct 23, 2025
2efe9bb
Merge branch 'main' into remove-simplecov-from-conformance-tests
woodruffw Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,6 @@ jobs:
xfail: "${{ matrix.ruby != 'head' && matrix.ruby != '3.4' && 'test_verify_rejects_bad_tsa_timestamp' }}"
environment: staging
if: ${{ matrix.os }} == "ubuntu-latest"
- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1
if: ${{ matrix.ruby }} == ${{ fromJson(needs.ruby-versions.outputs.latest) }} && ${{ matrix.os }} == "ubuntu-latest" && always()
with:
token: ${{ secrets.CODECOV_TOKEN }}
slug: sigstore/sigstore-ruby

tuf-conformance:
needs: ruby-versions
Expand Down Expand Up @@ -148,13 +142,6 @@ jobs:
if: |
${{ matrix.os }} == "ubuntu-latest"

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@13ce06bfc6bbe3ecf90edbbf1bc32fe5978ca1d3 # v5.3.1
if: ${{ matrix.ruby }} == ${{ fromJson(needs.ruby-versions.outputs.latest) }} && ${{ matrix.os }} == "ubuntu-latest" && always()
with:
token: ${{ secrets.CODECOV_TOKEN }}
slug: sigstore/sigstore-ruby

smoketest:
needs: ruby-versions
runs-on: ubuntu-latest
Expand Down
9 changes: 0 additions & 9 deletions bin/conformance-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,6 @@ require "tmpdir"

tmp = Dir.mktmpdir

require "simplecov"
SimpleCov.command_name "conformance:#{Digest::SHA256.hexdigest ARGV.join(" ")}"
load File.expand_path("../.simplecov", __dir__)
SimpleCov::Formatter::HTMLFormatter.module_eval do
def puts(...)
# Suppress output
end
end

ENV.update(
"HOME" => tmp,
"XDG_DATA_HOME" => nil,
Expand Down
11 changes: 0 additions & 11 deletions bin/tuf-conformance-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,6 @@ OptionParser.new do |parser|
end
end.parse!

require "simplecov"
SimpleCov.command_name "tuf-conformance:#{Digest::SHA256.hexdigest ARGV.map { |a|
a.sub(tmp, "$TMPDIR")
}.join(" ")}"
load File.expand_path("../.simplecov", __dir__)
SimpleCov::Formatter::HTMLFormatter.module_eval do
def puts(...)
# Suppress output
end
end

ARGV.prepend("tuf")
ARGV[2, 0] = args

Expand Down
Loading