Skip to content

Reset fullfillmentNeeded for new Roads #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reset fullfillmentNeeded for new Roads #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pages/MainPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,8 @@ export default {
_this.$store.commit('setRetrieved', newRoad);
});
} else if (newRoad !== '') {
// Reset fulfillmentNeeded so that new Roads still call FireRoad to check fulfillment.
this.$store.commit('resetFulfillmentNeeded');
Copy link
Collaborator

@georgiashay georgiashay Mar 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is calling update fulfillment twice when you create a new road while logged in (once on creation, once on name change). This should go specifically after a new road is added instead (in addRoad on MainPage).

this.updateFulfillment(this.$store.state.fulfillmentNeeded);
}
if (newRoad !== '') {
Expand Down