Fix file global function detection (#34)

* Add test case for calling a defined function

* Always look in the global scope

* Only look for defined functions for function calls

Author: sirbrillig

ImportDetection/Sniffs/Imports/RequireImportsSniff.php

@@ -157,7 +157,7 @@ private function isSymbolDefined(File $phpcsFile, Symbol $symbol): bool {
 			return $this->isNamespaceImported($phpcsFile, $namespace);
 		}
 		// If the symbol has no namespace and is itself is imported or defined, ignore it
-		return $this->isNamespaceImportedOrDefined($phpcsFile, $symbol->getName(), $symbol->getSymbolConditions());
+		return $this->isNamespaceImportedOrDefined($phpcsFile, $symbol);
 	}
 
 	private function isNamespaceImported(File $phpcsFile, string $namespace): bool {
@@ -168,12 +168,23 @@ private function isNamespaceImported(File $phpcsFile, string $namespace): bool {
 		);
 	}
 
-	private function isNamespaceImportedOrDefined(File $phpcsFile, string $namespace, array $conditions): bool {
+	private function isSymbolAFunctionCall(File $phpcsFile, Symbol $symbol): bool {
+		$tokens = $phpcsFile->getTokens();
+		$stackPtr = $symbol->getSymbolPosition();
+		if (isset($tokens[$stackPtr + 1]) && $tokens[$stackPtr + 1]['type'] === 'T_OPEN_PARENTHESIS') {
+			return true;
+		}
+		return false;
+	}
+
+	private function isNamespaceImportedOrDefined(File $phpcsFile, Symbol $symbol): bool {
+		$namespace = $symbol->getName();
+		$conditions = $symbol->getSymbolConditions();
 		return (
 			$this->isClassImported($phpcsFile, $namespace)
 			|| $this->isClassDefined($phpcsFile, $namespace)
 			|| $this->isFunctionImported($phpcsFile, $namespace)
-			|| $this->isFunctionDefined($phpcsFile, $namespace, $conditions)
+			|| $this->isFunctionDefined($phpcsFile, $symbol, $namespace, $conditions)
 			|| $this->isConstImported($phpcsFile, $namespace)
 			|| $this->isConstDefined($phpcsFile, $namespace)
 		);
@@ -250,17 +261,20 @@ private function isClassDefined(File $phpcsFile, string $className): bool {
 		return false;
 	}
 
-	private function isFunctionDefined(File $phpcsFile, string $functionName, array $conditions): bool {
+	private function isFunctionDefined(File $phpcsFile, Symbol $symbol, string $functionName, array $conditions): bool {
 		$tokens = $phpcsFile->getTokens();
+
+		if (! $this->isSymbolAFunctionCall($phpcsFile, $symbol)) {
+			return false;
+		}
+
 		$scopesToEnter = array_filter(array_keys($conditions), function ($conditionPtr) use ($conditions) {
 			return $conditions[$conditionPtr] === T_FUNCTION;
 		});
 		$this->debug("looking for definition for function {$functionName}");
 		$this->debug("my conditions are " . json_encode($conditions));
 		$this->debug("scopes to enter " . implode(',', $scopesToEnter));
-		if (empty($scopesToEnter)) {
-			return false;
-		}
+
 		// Only look at the inner-most scope and global scope
 		$scopesToEnter = [end($scopesToEnter), 0];
 

tests/Sniffs/Imports/WordPressFixture.php

@@ -78,3 +78,4 @@ public function test_additional_constants() {
 
 function foo() {}
 add_action('init', foo);
+foo();