Merge pull request #1150 from tildeio/drop-ruby-27

end support for ruby 2.7

Author: zvkemp

.github/workflows/build.yml

@@ -1,18 +1,35 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-10-29 17:01:45 UTC using RuboCop version 1.66.1.
+# on 2025-08-12 16:11:14 UTC using RuboCop version 1.70.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/OrderedGems:
+  Exclude:
+    - 'dummy/Gemfile'
+
+# Offense count: 1
+# Configuration parameters: Severity, Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'skylight.gemspec'
+
+# Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
+# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
 Layout/LineLength:
   Exclude:
-    - 'spec/integration/graphql_spec.rb'
+    - 'lib/skylight/probes/lambda.rb'
+    - 'spec/integration/delayed_job_spec.rb'
+    - 'spec/integration/initialization_spec.rb'
     - 'spec/unit/custom_instrumentation_spec.rb'
 
 # Offense count: 1
@@ -29,14 +46,6 @@ Lint/RedundantCopDisableDirective:
     - 'lib/skylight/util/clock.rb'
     - 'spec/integration/rails_spec.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: instance_of?, kind_of?, is_a?, eql?, respond_to?, equal?
-Lint/RedundantSafeNavigation:
-  Exclude:
-    - 'lib/skylight/normalizers/render.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Lint/RedundantStringCoercion:
@@ -45,11 +54,10 @@ Lint/RedundantStringCoercion:
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, consistent
-Lint/SymbolConversion:
+# Configuration parameters: AutoCorrect.
+Lint/UselessAssignment:
   Exclude:
-    - 'spec/spec_helper.rb'
+    - 'spec/unit/instrumenter_spec.rb'
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
@@ -77,7 +85,13 @@ Style/ExplicitBlockArgument:
     - 'lib/skylight/test.rb'
     - 'spec/support/messages/trace.rb'
 
-# Offense count: 242
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/FileNull:
+  Exclude:
+    - 'lib/skylight/cli/doctor.rb'
+
+# Offense count: 264
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -94,27 +108,22 @@ Style/HashEachMethods:
     - 'lib/skylight/probes/mongo.rb'
     - 'lib/tasks/workflow.rake'
 
-# Offense count: 3
+# Offense count: 4
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/MapIntoArray:
   Exclude:
     - 'spec/integration/graphql_spec.rb'
     - 'spec/integration/rails_spec.rb'
     - 'spec/integration/sinatra_spec.rb'
+    - 'spec/support/matchers.rb'
 
-# Offense count: 7
-Style/OpenStructUse:
-  Exclude:
-    - 'lib/skylight/cli/merger.rb'
-    - 'spec/unit/cli/merger_spec.rb'
-    - 'spec/unit/extensions/collection_spec.rb'
-    - 'spec/unit/extensions/source_location_spec.rb'
-
-# Offense count: 1
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
-Style/OperatorMethodCall:
+# Configuration parameters: AllowMethodComparison, ComparisonsThreshold.
+Style/MultipleComparison:
   Exclude:
-    - 'lib/skylight/util/logging.rb'
+    - 'lib/skylight/instrumenter.rb'
+    - 'lib/skylight/normalizers/sql.rb'
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
@@ -123,6 +132,13 @@ Style/RedundantRegexpArgument:
     - 'lib/skylight/native_ext_fetcher.rb'
     - 'lib/skylight/util/http.rb'
 
+# Offense count: 8
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantRegexpEscape:
+  Exclude:
+    - 'spec/integration/cli_spec.rb'
+    - 'spec/unit/cli/setup_spec.rb'
+
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantStringEscape:
@@ -147,7 +163,17 @@ Style/SafeNavigation:
     - 'lib/skylight/probes/net_http.rb'
     - 'lib/skylight/util/logging.rb'
 
-# Offense count: 2
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Exclude:
+    - 'dummy/Gemfile'
+    - 'dummy/config/environment.rb'
+    - 'dummy/lib/validate_skylight.rb'
+
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 Style/SuperArguments:
   Exclude:

.rubocop_todo.yml

@@ -1,6 +1,8 @@
-## 6.2.0.alpha (October 10, 2024)
+## 7.0.0.beta (July 31, 2025)
 
 - IMPROVEMENT Initial support for AWS Lambda
+- BREAKING end support for Ruby 2.7 and 3.0
+- BREAKING end support for Rails < 7.1
 
 ## 6.1.0.beta (June 11, 2024)
 

CHANGELOG.md

@@ -5,7 +5,7 @@ gemspec
 ruby ">= 2.7"
 
 gem "grape", "~> 2.2.0"
-gem "rails", "~> 7.1.0"
+gem "rails", "~> 8.0.0"
 gem "sinatra", "~> 3.0.0"
 
 eval_gemfile "./gemfiles/Gemfile.additional"

Gemfile

@@ -8,8 +8,8 @@ gem "graphql", "~> 2.0.18"
 gem "httpclient"
 gem "rexml"
 gem "sequel", "> 0"
-gem "sidekiq"
-gem "sqlite3", "~> 1.4.1"
+gem "sidekiq", "< 8"
+gem "sqlite3", "~> 2.1.0"
 gem "tilt"
 gem "haml"
 gem "redis"

gemfiles/Gemfile.additional

@@ -3,7 +3,7 @@ source "https://rubygems.org"
 gemspec path: "../.."
 
 # TODO: Check if we need Rails
-gem "rails", "~> 5.2.0"
-gem "sqlite3", "~> 1.4"
+gem "rails", "~> 7.2.0"
+gem "sqlite3", "~> 2"
 
 gem "active_model_serializers", "~> 0.9.5"

gemfiles/ams-0.8.x/Gemfile

@@ -3,8 +3,8 @@ source "https://rubygems.org"
 gemspec path: "../.."
 
 # TODO: Check if we need Rails
-gem "rails", "~> 6.1.0"
-gem "sqlite3", "~> 1.4"
+gem "rails", "~> 7.1.0"
+gem "sqlite3", "~> 2"
 
 gem "elasticsearch"