Skip to content

Commit fe0244e

Browse files
committed
simplify GetBlock proto
1 parent 0a1aaab commit fe0244e

File tree

11 files changed

+533
-440
lines changed

11 files changed

+533
-440
lines changed

pkg/capabilities/v2/protoc/pkg/test_capabilities/basictrigger/capabilities/internal/basictrigger/v1/basic_trigger.pb.go

Lines changed: 184 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/chains/solana/proto_helpers.go

Lines changed: 3 additions & 114 deletions
Original file line numberDiff line numberDiff line change
@@ -211,36 +211,6 @@ func ConvertConfirmationStatusFromProto(c ConfirmationStatusType) typesolana.Con
211211
}
212212
}
213213

214-
func ConvertTransactionDetailsFromProto(s TransactionDetailsType) typesolana.TransactionDetailsType {
215-
switch s {
216-
case TransactionDetailsType_TRANSACTION_DETAILS_FULL:
217-
return typesolana.TransactionDetailsFull
218-
case TransactionDetailsType_TRANSACTION_DETAILS_ACCOUNTS:
219-
return typesolana.TransactionDetailsAccounts
220-
case TransactionDetailsType_TRANSACTION_DETAILS_NONE:
221-
return typesolana.TransactionDetailsNone
222-
case TransactionDetailsType_TRANSCTION_DETAILS_SIGNATURES:
223-
return typesolana.TransactionDetailsSignatures
224-
default:
225-
return typesolana.TransactionDetailsType("")
226-
}
227-
}
228-
229-
func ConvertTransactionDetailsToProto(t typesolana.TransactionDetailsType) TransactionDetailsType {
230-
switch t {
231-
case typesolana.TransactionDetailsAccounts:
232-
return TransactionDetailsType_TRANSACTION_DETAILS_ACCOUNTS
233-
case typesolana.TransactionDetailsNone:
234-
return TransactionDetailsType_TRANSACTION_DETAILS_NONE
235-
case typesolana.TransactionDetailsSignatures:
236-
return TransactionDetailsType_TRANSCTION_DETAILS_SIGNATURES
237-
case typesolana.TransactionDetailsFull:
238-
return TransactionDetailsType_TRANSACTION_DETAILS_FULL
239-
default:
240-
return TransactionDetailsType_TRANSACTION_DETAILS_FULL
241-
}
242-
}
243-
244214
func ConvertDataSliceFromProto(p *DataSlice) *typesolana.DataSlice {
245215
if p == nil {
246216
return nil
@@ -409,32 +379,16 @@ func ConvertGetBlockOptsFromProto(p *GetBlockOpts) *typesolana.GetBlockOpts {
409379
return nil
410380
}
411381
return &typesolana.GetBlockOpts{
412-
Encoding: ConvertEncodingTypeFromProto(p.Encoding),
413-
TransactionDetails: ConvertTransactionDetailsFromProto(p.TransactionDetails),
414-
Rewards: ptrBool(p.Rewards),
415-
Commitment: ConvertCommitmentFromProto(p.Commitment),
416-
MaxSupportedTransactionVersion: ptrUint64(p.MaxSupportedTransactionVersion),
382+
Commitment: ConvertCommitmentFromProto(p.Commitment),
417383
}
418384
}
419385

420386
func ConvertGetBlockOptsToProto(o *typesolana.GetBlockOpts) *GetBlockOpts {
421387
if o == nil {
422388
return nil
423389
}
424-
var rewards bool
425-
if o.Rewards != nil {
426-
rewards = *o.Rewards
427-
}
428-
var maxv uint64
429-
if o.MaxSupportedTransactionVersion != nil {
430-
maxv = *o.MaxSupportedTransactionVersion
431-
}
432390
return &GetBlockOpts{
433-
Encoding: ConvertEncodingTypeToProto(o.Encoding),
434-
TransactionDetails: ConvertTransactionDetailsToProto(o.TransactionDetails),
435-
Rewards: rewards,
436-
Commitment: ConvertCommitmentToProto(o.Commitment),
437-
MaxSupportedTransactionVersion: maxv,
391+
Commitment: ConvertCommitmentToProto(o.Commitment),
438392
}
439393
}
440394

@@ -808,47 +762,6 @@ func ConvertTransactionEnvelopeToProto(e typesolana.TransactionResultEnvelope) *
808762
}
809763
}
810764

811-
func ConvertTransactionWithMetaFromProto(p *TransactionWithMeta) (*typesolana.TransactionWithMeta, error) {
812-
if p == nil {
813-
return nil, nil
814-
}
815-
env, err := ConvertDataBytesOrJSONFromProto(p.Transaction)
816-
if err != nil {
817-
return nil, fmt.Errorf("transaction bytes/json: %w", err)
818-
}
819-
meta, err := ConvertTransactionMetaFromProto(p.Meta)
820-
if err != nil {
821-
return nil, fmt.Errorf("meta: %w", err)
822-
}
823-
t := typesolana.UnixTimeSeconds(p.BlockTime)
824-
825-
return &typesolana.TransactionWithMeta{
826-
Slot: p.Slot,
827-
BlockTime: &t,
828-
Transaction: env,
829-
Meta: meta,
830-
Version: typesolana.TransactionVersion(p.Version),
831-
}, nil
832-
}
833-
834-
func ConvertTransactionWithMetaToProto(t *typesolana.TransactionWithMeta) *TransactionWithMeta {
835-
if t == nil {
836-
return nil
837-
}
838-
var bt int64
839-
if t.BlockTime != nil {
840-
bt = int64(*t.BlockTime)
841-
}
842-
843-
return &TransactionWithMeta{
844-
Slot: t.Slot,
845-
BlockTime: bt,
846-
Transaction: ConvertDataBytesOrJSONToProto(t.Transaction),
847-
Meta: ConvertTransactionMetaToProto(t.Meta),
848-
Version: int64(t.Version),
849-
}
850-
}
851-
852765
func ConvertGetTransactionReplyFromProto(p *GetTransactionReply) (*typesolana.GetTransactionReply, error) {
853766
if p == nil {
854767
return nil, nil
@@ -972,22 +885,7 @@ func ConvertGetBlockOptsReplyFromProto(p *GetBlockReply) (*typesolana.GetBlockRe
972885
if err != nil {
973886
return nil, fmt.Errorf("previous blockhash: %w", err)
974887
}
975-
txs := make([]typesolana.TransactionWithMeta, 0, len(p.Transactions))
976-
for _, tx := range p.Transactions {
977-
twm, err := ConvertTransactionWithMetaFromProto(tx)
978-
if err != nil {
979-
return nil, err
980-
}
981-
txs = append(txs, *twm)
982-
}
983-
var sigs []typesolana.Signature
984-
for _, s := range p.Signatures {
985-
ss, err := ConvertSignatureFromProto(s)
986-
if err != nil {
987-
return nil, err
988-
}
989-
sigs = append(sigs, ss)
990-
}
888+
991889
var bt *solana.UnixTimeSeconds
992890
if p.BlockTime != 0 {
993891
bt = ptrUnix(typesolana.UnixTimeSeconds(p.BlockTime))
@@ -996,8 +894,6 @@ func ConvertGetBlockOptsReplyFromProto(p *GetBlockReply) (*typesolana.GetBlockRe
996894
Blockhash: hash,
997895
PreviousBlockhash: prev,
998896
ParentSlot: p.ParentSlot,
999-
Transactions: txs,
1000-
Signatures: sigs,
1001897
BlockTime: bt,
1002898
BlockHeight: ptrUint64(p.BlockHeight),
1003899
}, nil
@@ -1015,17 +911,10 @@ func ConvertGetBlockReplyToProto(r *typesolana.GetBlockReply) *GetBlockReply {
1015911
if r.BlockHeight != nil {
1016912
bh = *r.BlockHeight
1017913
}
1018-
txs := make([]*TransactionWithMeta, 0, len(r.Transactions))
1019-
for i := range r.Transactions {
1020-
txs = append(txs, ConvertTransactionWithMetaToProto(&r.Transactions[i]))
1021-
}
1022-
sigs := ConvertSignaturesToProto(r.Signatures)
1023914
return &GetBlockReply{
1024915
Blockhash: r.Blockhash[:],
1025916
PreviousBlockhash: r.PreviousBlockhash[:],
1026917
ParentSlot: r.ParentSlot,
1027-
Transactions: txs,
1028-
Signatures: sigs,
1029918
BlockTime: bt,
1030919
BlockHeight: bh,
1031920
}

0 commit comments

Comments
 (0)