Commit 5e38507
feat: treat sbatch errors as job errors instead of workflow errors (#322)
fixes
#320
When I do some very rudimentary testing it seems to work: when sbatch
fails, it is handled like a job error rather than a workflow error.
The argument for `report_job_error` needs to be a `SubmittedJobInfo`.
These jobs are technically never reported as submitted. I'm not sure if
that would cause some type of problem? Would this PR need some sort of
tests included?
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved error handling during SLURM job submission to prevent
unnecessary interruptions when an error occurs, ensuring smoother
workflow execution.
- Fixed minor formatting issue related to job status checking for more
accurate time calculations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: Christian Meesters <[email protected]>1 parent bf4fcd1 commit 5e38507
1 file changed
+9
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
366 | 366 | | |
367 | 367 | | |
368 | 368 | | |
369 | | - | |
370 | | - | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
371 | 376 | | |
| 377 | + | |
372 | 378 | | |
373 | 379 | | |
374 | 380 | | |
| |||
445 | 451 | | |
446 | 452 | | |
447 | 453 | | |
448 | | - | |
| 454 | + | |
449 | 455 | | |
450 | 456 | | |
451 | 457 | | |
| |||
0 commit comments