Skip to content

fix: validator check for integers was broken. #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmeesters merged 2 commits into from
Dec 1, 2025
Merged

fix: validator check for integers was broken. #381

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2273aa
fix: validator check for integers was broken.
cmeesters Dec 1, 2025
47a5d7c
fix: stricter checking
cmeesters Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion snakemake_executor_plugin_slurm/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def validate_executor_settings(settings, logger=None):
if settings.init_seconds_before_status_checks is not None:
if (
not isinstance(settings.init_seconds_before_status_checks, int)
or settings.init_seconds_before_status_checks > 0
or settings.init_seconds_before_status_checks < 0
):
raise WorkflowError(
"init-seconds-before-status-checks must be a positive integer."
Expand Down