-
Notifications
You must be signed in to change notification settings - Fork 150
SNOW-2882054 fix for uploading azure metadata #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SNOW-2882054 fix for uploading azure metadata #1288
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
- Coverage 87.68% 87.50% -0.19%
==========================================
Files 194 194
Lines 16122 16177 +55
Branches 1683 1684 +1
==========================================
+ Hits 14136 14155 +19
- Misses 1544 1579 +35
- Partials 442 443 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, But we have multiple tests failing. Do we know a reason?
Snowflake.Data/Core/FileTransfer/StorageClient/SFSnowflakeAzureClient.cs
Outdated
Show resolved
Hide resolved
Will check on that Monday. Meanwhile will try to do some testing |
56fc8b6 to
96bf899
Compare
|
@sfc-gh-fpawlowski Tests on mocks were mocking the method already not called |
7fb4887 to
c39bb2e
Compare
Description
Blob & metadata upload in a single operation preventing accidental intermittent network issues in between the calls.
Testing (if possible) in next PR.
Checklist
dotnet test)