Skip to content

Conversation

@sfc-gh-mhofman
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman commented Dec 5, 2025

Description

Blob & metadata upload in a single operation preventing accidental intermittent network issues in between the calls.
Testing (if possible) in next PR.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-mhofman sfc-gh-mhofman requested a review from a team as a code owner December 5, 2025 16:29
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 53.84615% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.50%. Comparing base (763aca7) to head (c39bb2e).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...leTransfer/StorageClient/SFSnowflakeAzureClient.cs 53.84% 29 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
- Coverage   87.68%   87.50%   -0.19%     
==========================================
  Files         194      194              
  Lines       16122    16177      +55     
  Branches     1683     1684       +1     
==========================================
+ Hits        14136    14155      +19     
- Misses       1544     1579      +35     
- Partials      442      443       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sfc-gh-fpawlowski sfc-gh-fpawlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, But we have multiple tests failing. Do we know a reason?

@sfc-gh-mhofman
Copy link
Collaborator Author

Lgtm, But we have multiple tests failing. Do we know a reason?

Will check on that Monday. Meanwhile will try to do some testing

@sfc-gh-mhofman sfc-gh-mhofman force-pushed the SNOW-2882054-fix-for-uploading-azure-metadata branch from 56fc8b6 to 96bf899 Compare December 5, 2025 19:20
@sfc-gh-mhofman
Copy link
Collaborator Author

@sfc-gh-fpawlowski Tests on mocks were mocking the method already not called

@sfc-gh-mhofman sfc-gh-mhofman force-pushed the SNOW-2882054-fix-for-uploading-azure-metadata branch from 7fb4887 to c39bb2e Compare December 5, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants