Pass clicked element to dynamic context functions for button click tracking plugin (close #1368)

irenehakes · matus-tomlein · commit 5d58a0f4d0d6 · 2024-11-28T11:56:33.000+01:00
PR #1389
diff --git a/common/changes/@snowplow/browser-plugin-button-click-tracking/issue-1368_2024-11-22-08-27.json b/common/changes/@snowplow/browser-plugin-button-click-tracking/issue-1368_2024-11-22-08-27.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@snowplow/browser-plugin-button-click-tracking",
+      "comment": "Pass clicked element to dynamic context functions for button click tracking plugin (#1368)",
+      "type": "none"
+    }
+  ],
+  "packageName": "@snowplow/browser-plugin-button-click-tracking"
+}
diff --git a/plugins/browser-plugin-button-click-tracking/src/api.ts b/plugins/browser-plugin-button-click-tracking/src/api.ts
@@ -102,7 +102,7 @@ function eventHandler(event: MouseEvent, trackerId: string, filter: FilterFuncti
     if (elem instanceof HTMLButtonElement || (elem instanceof HTMLInputElement && elem.type === 'button')) {
       if (filter(elem)) {
         const buttonClickEvent = createEventFromButton(elem);
-        buttonClickEvent.context = resolveDynamicContext(context, buttonClickEvent);
+        buttonClickEvent.context = resolveDynamicContext(context, buttonClickEvent, elem);
         trackButtonClick(buttonClickEvent, [trackerId]);
       }
       // presume nested buttons aren't a thing

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ function eventHandler(event: MouseEvent, trackerId: string, filter: FilterFuncti`
`102`	`102`	`if (elem instanceof HTMLButtonElement \|\| (elem instanceof HTMLInputElement && elem.type === 'button')) {`
`103`	`103`	`if (filter(elem)) {`
`104`	`104`	`const buttonClickEvent = createEventFromButton(elem);`
`105`		`- buttonClickEvent.context = resolveDynamicContext(context, buttonClickEvent);`
	`105`	`+ buttonClickEvent.context = resolveDynamicContext(context, buttonClickEvent, elem);`
`106`	`106`	`trackButtonClick(buttonClickEvent, [trackerId]);`
`107`	`107`	`}`
`108`	`108`	`// presume nested buttons aren't a thing`