Skip to content

Add test for OPTIONS * handling. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samuel-williams-shopify merged 1 commit into from
Dec 5, 2025
Merged

Add test for OPTIONS * handling. #28

samuel-williams-shopify merged 1 commit into from
Dec 5, 2025

Conversation

@samuel-williams-shopify
Copy link
Contributor

@samuel-williams-shopify samuel-williams-shopify commented Dec 4, 2025 •
edited
Loading

I wasn't sure how this was handled, so I added a test.

Types of Changes

  • New feature.

Contribution

@samuel-williams-shopify samuel-williams-shopify changed the title Add test for OPTIONS * handling. Add test for OPTIONS * handling. Dec 4, 2025
@samuel-williams-shopify
Copy link
Contributor Author

samuel-williams-shopify commented Dec 4, 2025

@CamJN @FooBarWidget I can't get Phusion Passenger to accept OPTIONS * but OPTIONS / does work:

> curl -X OPTIONS --request-target "*" http://localhost:3000 -v
* Host localhost:3000 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
*   Trying [::1]:3000...
* connect to ::1 port 3000 from ::1 port 59649 failed: Connection refused
*   Trying 127.0.0.1:3000...
* Connected to localhost (127.0.0.1) port 3000
> OPTIONS * HTTP/1.1
> Host: localhost:3000
> User-Agent: curl/8.7.1
> Accept: */*
> 
* Request completely sent off
< HTTP/1.1 400 Bad Request
< Server: nginx/1.26.3
< Date: Thu, 04 Dec 2025 22:58:19 GMT
< Content-Type: text/html
< Content-Length: 157
< Connection: close
< 
<html>
<head><title>400 Bad Request</title></head>
<body>
<center><h1>400 Bad Request</h1></center>
<hr><center>nginx/1.26.3</center>
</body>
</html>
* Closing connection


> curl -X OPTIONS --request-target "/" http://localhost:3000 -v
* Host localhost:3000 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
*   Trying [::1]:3000...
* connect to ::1 port 3000 from ::1 port 59845 failed: Connection refused
*   Trying 127.0.0.1:3000...
* Connected to localhost (127.0.0.1) port 3000
> OPTIONS / HTTP/1.1
> Host: localhost:3000
> User-Agent: curl/8.7.1
> Accept: */*
> 
* Request completely sent off
< HTTP/1.1 200 OK
< Content-Length: 9
< Connection: keep-alive
< Status: 200 OK
< allow: GET, POST, PUT, PATCH, DELETE, OPTIONS
< Date: Thu, 04 Dec 2025 23:01:37 GMT
< X-Powered-By: Phusion Passenger(R) 6.1.0
< Server: nginx/1.26.3 + Phusion Passenger(R) 6.1.0
< 
* Connection #0 to host localhost left intact
OPTIONS /

Is this a bug with Passenger? Why isn't it forwarding the request?

@samuel-williams-shopify
Copy link
Contributor Author

samuel-williams-shopify commented Dec 5, 2025

I merged #29 as it felt like a useful test and was working correctly across all servers.

@ioquatix ioquatix mentioned this pull request Dec 5, 2025
Merged
@samuel-williams-shopify samuel-williams-shopify force-pushed the options-star branch 9 times, most recently from 57bf1f2 to f655122 Compare December 5, 2025 12:47
@samuel-williams-shopify
Copy link
Contributor Author

samuel-williams-shopify commented Dec 5, 2025

I've decided to support explicit broken-ness and listed Passenger as having broken support for OPTIONS *. If it gets fixed, please let me know.

@samuel-williams-shopify samuel-williams-shopify merged commit f87f8fb into main Dec 5, 2025
20 checks passed
@samuel-williams-shopify samuel-williams-shopify deleted the options-star branch December 5, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samuel-williams-shopify