File tree Expand file tree Collapse file tree 2 files changed +11
-6
lines changed
Expand file tree Collapse file tree 2 files changed +11
-6
lines changed Original file line number Diff line number Diff line change @@ -11,6 +11,7 @@ use dap::base_message::Sendable;
1111use dap:: errors:: ServerError ;
1212use dap:: prelude:: { Event , Request , ResponseBody , Server } ;
1313use dap:: server:: { ServerReader , ServerWriter } ;
14+ use tracing:: error;
1415
1516pub struct Connection {
1617 inbound_rx : mpsc:: Receiver < Request > ,
@@ -107,7 +108,7 @@ fn spawn_reader_thread(
107108 thread:: spawn ( move || {
108109 while let Ok ( Some ( request) ) = server_reader. poll_request ( ) {
109110 if inbound_tx. send ( request) . is_err ( ) {
110- // TODO: Add error tracing
111+ error ! ( "Inbound channel closed" ) ;
111112 break ;
112113 }
113114 }
Original file line number Diff line number Diff line change @@ -2,7 +2,7 @@ use anyhow::{Result, bail};
22use cairo_vm:: vm:: vm_core:: VirtualMachine ;
33use dap:: events:: ExitedEventBody ;
44use dap:: prelude:: Event :: { Exited , Terminated } ;
5- use tracing:: debug;
5+ use tracing:: { debug, error } ;
66
77use crate :: connection:: Connection ;
88use crate :: debugger:: handler:: { HandleResult , NextAction } ;
@@ -64,9 +64,13 @@ impl CairoDebugger {
6464
6565impl Drop for CairoDebugger {
6666 fn drop ( & mut self ) {
67- // TODO: Add error tracing
68- // TODO: Send correct exit code
69- self . connection . send_event ( Terminated ( None ) ) . ok ( ) ;
70- self . connection . send_event ( Exited ( ExitedEventBody { exit_code : 0 } ) ) . ok ( ) ;
67+ if let Err ( err) = self . connection . send_event ( Terminated ( None ) ) {
68+ error ! ( "Sending terminated event failed: {}" , err) ;
69+ }
70+
71+ // TODO(#34): Send correct exit code
72+ if let Err ( err) = self . connection . send_event ( Exited ( ExitedEventBody { exit_code : 0 } ) ) {
73+ error ! ( "Sending exit event failed: {}" , err) ;
74+ }
7175 }
7276}
You can’t perform that action at this time.
0 commit comments