feat(realtime): add phoenixAdapter, change RealtimePresence, add github as dependency #2
Conversation
GuzekAlan
changed the base branch from
feat/add-phoenix-adapter-basics
to
feat/use-phoenix-in-realtime-js
GuzekAlan
changed the title
GuzekAlan
changed the title
There was a problem hiding this comment.
that's for future I think, but once we expose constants in phoenix fork, if we add something to those constants we should spread original one (and add more) or reexport them from this file for consistency
| /** | ||
| * @private | ||
| */ | ||
| getPresence(): Presence { | ||
| return this.presence | ||
| } |
There was a problem hiding this comment.
nitpick: not needed
| * | ||
| */ | ||
| function transformState(state: State): RealtimePresenceState { | ||
| state = cloneDeep(state) |
There was a problem hiding this comment.
question: is cloning needed here?
There was a problem hiding this comment.
Both of these functions are copied from the RealtimePresence and I haven't changed how they work. Once we have working sutff and tests to ensure nofing breaks we can modify and reafctor already existing code.
| function cloneDeep(obj: { [key: string]: any }) { | ||
| return JSON.parse(JSON.stringify(obj)) | ||
| } |
There was a problem hiding this comment.
nitpick: you should make it generic, as this should return the same type on input
| } | ||
|
|
||
| function cloneDeep(obj: { [key: string]: any }) { | ||
| return JSON.parse(JSON.stringify(obj)) |
There was a problem hiding this comment.
nitpick: i don't like that method of cloning
maybe this? mdn says it's supported by majors browsers, but we could still polyfill this just in case
| } | ||
|
|
||
| trigger(type: string, payload: object, ref?: string): void { | ||
| //@ts-ignore - trigger should be public |
There was a problem hiding this comment.
Oh okay I thought those were the ones you've added before I made the PR to the subabase/phoenix
| /** | ||
| * @private | ||
| */ | ||
| getChannel(): Channel { | ||
| return this.channel | ||
| } |
There was a problem hiding this comment.
these private functions. They are not used in the class so either they should be deleted or made public.
No description provided.