You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(iOS): fix header height in modal, add TestHeaderHeight (#3393)
## Description
Fixes header height in modal with `headerShown: true`. Prior to this PR,
header height was sometimes incorrect and did not update dynamically,
e.g. when search bar was enabled with `hideWhenScrolling: true`.
Adds `TestHeaderHeight` test screen.
| before | after |
| --- | --- |
| <video
src="https://github.com/user-attachments/assets/2fb62d71-91d8-41d1-9e21-d86e4fa8c19f"
/> | <video
src="https://github.com/user-attachments/assets/7e2b5431-fbc1-484a-9eb1-8bfcfab65f66"
/> |
## Changes
- pass `onHeaderHeightChange` callback to correct `Screen`
- create `TestHeaderHeight`
- extract `LongText` to shared components directory
## Test code and steps to reproduce
Run `TestHeaderHeight`. Set `headerTransparent: true`, `presentation:
modal`, `content: scrollView`, `searchBarPlacement: stacked`. Scroll up
to see the search bar. Note header height values being updated.
## Checklist
- [x] Included code example that can be used to test this change
- [x] Ensured that CI passes
'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce sed egestas felis. Proin laoreet eros a tellus elementum, quis euismod enim gravida. Morbi at arcu commodo, condimentum purus a, congue sapien. Nunc luctus molestie enim ut mattis. Pellentesque sollicitudin, arcu nec sodales gravida, tortor mauris dignissim urna, nec venenatis nibh ex ut odio. Donec rhoncus arcu eu pulvinar cursus. Sed id ullamcorper erat. Proin mollis a mi vitae posuere. Integer a pretium tellus, vel faucibus metus. Pellentesque non lorem ullamcorper, auctor tellus vulputate, eleifend metus. Aenean in semper erat. Ut arcu elit, semper et dolor eu, pharetra ornare dui. Donec ac condimentum tellus, sed consequat tortor. Etiam facilisis diam sit amet felis rhoncus aliquet. Vestibulum pharetra sapien in tellus pharetra, vel rhoncus ipsum pharetra. Mauris eget porttitor nulla. Vestibulum blandit neque in molestie laoreet. Aliquam semper risus sit amet augue hendrerit suscipit. Vivamus eleifend aliquam congue. Mauris id volutpat neque. Donec erat justo, dictum quis ultrices sit amet, fermentum vel augue. Donec ut velit sit amet mauris tincidunt tincidunt.';
0 commit comments