flask bug fix due to detached context

Author: Sonu Kumar

error_tracker/flask/flask_error.py

@@ -215,7 +215,7 @@ def create_or_update_entity(cls, rhash, host, path, method, request_data,
             @classmethod
             def get_exceptions_per_page(cls, page_number=1):
                 return cls.query.order_by(desc(cls.last_seen)).paginate(
-                    page_number, page_size, False)
+                    page=page_number, per_page=page_size, error_out=False)
 
             @classmethod
             def get_entity(cls, rhash):
@@ -285,10 +285,11 @@ def capture_exception(self, additional_context=None):
 
         ty, frames, frame_str, traceback_str, rhash, request_data = \
             get_context_detail(rq, self.masking, self.context_builder, additional_context)
-        error = self.model.create_or_update_entity(rhash, host, path, method,
-                                                   str(request_data),
-                                                   get_exception_name(ty),
-                                                   traceback_str)
+        with self.app.app_context():
+            error = self.model.create_or_update_entity(rhash, host, path, method,
+                                                       str(request_data),
+                                                       get_exception_name(ty),
+                                                       traceback_str)
         self._post_process(rq, frame_str, frames, error)
 
     def auto_track_exception(self, func, additional_context=None, silent=False):
@@ -329,7 +330,8 @@ def get_exceptions(self, page_number=1):
         :return: list of exception objects
         """
         if self.model:
-            return self.model.get_exceptions_per_page(page_number=page_number).items
+            with self.app.app_context():
+                return self.model.get_exceptions_per_page(page_number=page_number).items
         raise ConfigError
 
     def get_exception(self, rhash):
@@ -339,7 +341,8 @@ def get_exception(self, rhash):
         :return:  exception object
         """
         if self.model:
-            return self.model.get_entity(rhash)
+            with self.app.app_context():
+                return self.model.get_entity(rhash)
         raise ConfigError
 
     def delete_exception(self, rhash):
@@ -349,12 +352,14 @@ def delete_exception(self, rhash):
         :return:   whatever model returns
         """
         if self.model:
-            return self.model.delete_entity(rhash)
+            with self.app.app_context():
+                return self.model.delete_entity(rhash)
         raise ConfigError
 
     def create_or_update_exception(self, rhash, host, path, method, request_data,
                                    exception_name, traceback):
         if self.model:
-            return self.model.create_or_update_entity(rhash, host, path, method, request_data,
-                                                      exception_name, traceback)
+            with self.app.app_context():
+                return self.model.create_or_update_entity(rhash, host, path, method, request_data,
+                                                          exception_name, traceback)
         raise ConfigError

run-tests.sh

@@ -4,4 +4,4 @@ for tst in tests/DjangoTest/runners/*.py; do
   python "$tst"
 done
 
-#python tests/flask-test-runner.py
+python tests/flask-test-runner.py

tests/FlaskTest/test_end_point.py

@@ -69,18 +69,19 @@ def test_pagination(self):
             exception = error_tracker.get_exceptions()[0]
             hashx = exception.hash
             inserted = 0
-            i = 0
             while inserted < 20:
-                i += 1
-                idx = str(i) + hashx[2:]
                 inserted += 1
+                idx = str(inserted) + hashx[2:]
+                print("Inserting ", idx)
                 error_tracker.create_or_update_exception(idx, exception.host, exception.path,
                                                          exception.method, exception.request_data,
                                                          exception.exception_name,
                                                          exception.traceback)
 
+
             response = c.get('/dev/error', follow_redirects=True)
-            urls = [node.attrib['href'] for node in pyquery.PyQuery(response.data)('a')]
+            data = response.data
+            urls = [node.attrib['href'] for node in pyquery.PyQuery(data)('a')]
             self.assertEqual(len(urls), pagination_config.APP_DEFAULT_LIST_SIZE * 2 + 1)
             self.assertTrue('/dev/error/?page=2' in urls)
 

tests/FlaskTest/test_init_later.py

@@ -24,8 +24,9 @@ def _setup(self, db_file):
         db = SQLAlchemy(app)
         error_tracker = AppErrorTracker()
         error_tracker.init_app(app, db, view_permission=ViewPermission())
-        db.drop_all()
-        db.create_all()
+        with app.app_context():
+            db.drop_all()
+            db.create_all()
         return app, db, error_tracker
 
 

tests/FlaskTest/utils.py

@@ -97,6 +97,7 @@ def _setup(self, db_file):
         app.config['SQLALCHEMY_DATABASE_URI'] = "sqlite:///%s" % db_file
         db = SQLAlchemy(app)
         error_tracker = AppErrorTracker(app=app, db=db, view_permission=ViewPermission(), **self.kwargs)
-        db.drop_all()
-        db.create_all()
+        with app.app_context():
+            db.drop_all()
+            db.create_all()
         return app, db, error_tracker