fix: Handle non-TTY output for progress bar (#405)

Author: varungandhi-src

indexer/ProgressReporter.cc

@@ -1,5 +1,6 @@
 #include <cmath>
 #include <cstdint>
+#include <filesystem>
 #include <iostream>
 #include <ostream>
 #include <string_view>
@@ -12,12 +13,20 @@ namespace scip_clang {
 
 ProgressReporter::ProgressReporter(bool active, std::string_view msg,
                                    size_t totalCount)
-    : message(msg), totalCount(totalCount), countWidth(), active(active) {
+    : message(msg), totalCount(totalCount), countWidth(), active(active),
+      isTty(false) {
   if (this->totalCount == 0) {
     countWidth = 1;
   } else {
     countWidth = std::log10(double(this->totalCount)) + 1;
   }
+#if __linux__ || __APPLE__
+  std::error_code ec;
+  auto status = std::filesystem::status("/dev/stdout", ec);
+  if (!ec) {
+    this->isTty = (status.type() == std::filesystem::file_type::character);
+  }
+#endif
 }
 
 void ProgressReporter::report(size_t count, std::string_view extraData) const {
@@ -26,14 +35,19 @@ void ProgressReporter::report(size_t count, std::string_view extraData) const {
   }
   int maxExtraWidth = 256;
   auto backspaceCount = std::max(maxExtraWidth - int(extraData.size()), 0);
-  fmt::print("\r[{1:>{0}}/{2:>{0}}] {3} {4:<{5}}{6:\b<{7}}", countWidth, count,
-             this->totalCount, this->message, extraData, maxExtraWidth, "",
-             backspaceCount);
+  if (this->isTty) {
+    fmt::print("\r[{1:>{0}}/{2:>{0}}] {3} {4:<{5}}{6:\b<{7}}", countWidth,
+               count, this->totalCount, this->message, extraData, maxExtraWidth,
+               "", backspaceCount);
+  } else {
+    fmt::print("[{1:>{0}}/{2:>{0}}] {3} {4}\n", countWidth, count,
+               this->totalCount, this->message, extraData);
+  }
   std::flush(std::cout);
 }
 
 ProgressReporter::~ProgressReporter() {
-  if (this->active) {
+  if (this->active && this->isTty) {
     fmt::print("\n");
   }
 }

indexer/ProgressReporter.h

@@ -11,6 +11,7 @@ class ProgressReporter {
   size_t totalCount;
   size_t countWidth;
   bool active;
+  bool isTty;
 
 public:
   ProgressReporter(bool active, std::string_view msg, size_t totalCount);