Support external verification status tracking in job verification page #14
Conversation
✅ Deploy Preview for verify-sourcify-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
app/routes/jobs.$jobId.tsx
Outdated
| <p className="text-sm text-gray-500">Statuses refresh every {EXTERNAL_VERIFICATION_STATUS_REFRESH_RATE_SECONDS} seconds.</p> | ||
| </div> | ||
| <div className="space-y-4"> | ||
| {Object.entries(jobData.externalVerifications) |
There was a problem hiding this comment.
Can we order the verifiers? I would do it by adoption, which should be in this order: Etherscan, Blockscout, Routescan.
There was a problem hiding this comment.
I would actually put Etherscan last because it's not part of the verifier alliance :)
marcocastignoli
moved this from Sprint - In Progress
to Sprint - Needs Review
in Sourcify Public
| // Old jobs don't have external verifications, so we need a mechanism to stop retrying if the value is not set | ||
| if (!jobData || isJobFullyCompleted || hasReachedExternalVerificationRetryLimit) return; | ||
|
|
There was a problem hiding this comment.
The name isJobFullyCompleted is a bit misleading here. I spend a good 10 mins trying to understand how this variable relates to the comment above. Finally realized it also has a check if the externalVerification field exists, which I can't understand from the variable name
| return ( | ||
| <div className="bg-white rounded-lg shadow-sm border border-gray-200 p-4 md:p-6 my-6 md:my-8"> | ||
| <div className="flex flex-col md:flex-row md:items-center md:justify-between gap-2 md:gap-4 mb-4"> | ||
| <h2 className="text-lg md:text-xl font-bold text-gray-900">Verification on other verifiers</h2> |
There was a problem hiding this comment.
Let's just say "Other Verifiers" in the title and add a small subtitle saying "Sourcify automatically shares contracts with other known verifiers"
Smaller action points I see:
|
|
I found that Routescan stores the verification job for 24 minutes. So that error comes from this problem. I don't know what we can do about it... Should we use the verification creation time to mark the row as "verification too old" or something similar? EDIT: it's probably not something related only to Routescan, I'm asking also Blockscout |
See argotorg/sourcify#2425