Fixing checkstyle error

ryanjbaxter · ryanjbaxter · commit ef222bce7a88 · 2025-11-21T15:51:44.000-05:00
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/EagerInitFeignClientUsingConfigurerTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/EagerInitFeignClientUsingConfigurerTests.java
@@ -165,7 +165,7 @@ interface NoInheritFeignClient {
 
 	}
 
-	private static class NoOpCapability implements Capability {
+	private static final class NoOpCapability implements Capability {
 
 	}
 
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientDisabledClientLevelFeaturesTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientDisabledClientLevelFeaturesTests.java
@@ -117,7 +117,7 @@ public Capability noOpCapability() {
 
 	}
 
-	private static class NoOpCapability implements Capability {
+	private static final class NoOpCapability implements Capability {
 
 	}
 
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientDisabledFeaturesTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientDisabledFeaturesTests.java
@@ -112,7 +112,7 @@ public Capability noOpCapability() {
 
 	}
 
-	private static class NoOpCapability implements Capability {
+	private static final class NoOpCapability implements Capability {
 
 	}
 
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientOverrideDefaultsTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientOverrideDefaultsTests.java
@@ -326,11 +326,11 @@ private static class TestMicrometerObservationCapability extends feign.micromete
 
 	}
 
-	private static class TestMicrometerCapability extends feign.micrometer.MicrometerCapability {
+	private static final class TestMicrometerCapability extends feign.micrometer.MicrometerCapability {
 
 	}
 
-	private static class NoOpCapability implements Capability {
+	private static final class NoOpCapability implements Capability {
 
 	}
 
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientUsingPropertiesTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/FeignClientUsingPropertiesTests.java
@@ -475,7 +475,7 @@ public void encode(Object o, Type type, RequestTemplate requestTemplate) throws
 
 	}
 
-	public static class NoOpCapability implements Capability {
+	public static final class NoOpCapability implements Capability {
 
 	}
 
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/LazyInitFeignClientUsingConfigurerTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/LazyInitFeignClientUsingConfigurerTests.java
@@ -172,7 +172,7 @@ interface NoInheritFeignClient {
 
 	}
 
-	private static class NoOpCapability implements Capability {
+	private static final class NoOpCapability implements Capability {
 
 	}
 
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/circuitbreaker/FallbackSupportFactoryBeanTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/circuitbreaker/FallbackSupportFactoryBeanTests.java
@@ -90,7 +90,7 @@ void shouldRunFallbackFromBeanOrFactoryBean() {
 	@EnableFeignClients(clients = { FallbackSupportFactoryBeanTests.OriginalFeign.class,
 			FallbackSupportFactoryBeanTests.FactoryBeanFallbackFeign.class })
 	@EnableAutoConfiguration
-	private static class TestConfiguration {
+	private static final class TestConfiguration {
 
 	}
 
@@ -110,7 +110,7 @@ interface FactoryBeanFallbackFeign {
 
 	}
 
-	private static class FactoryBeanFallbackFeignFallback implements FactoryBean<FactoryBeanFallbackFeign> {
+	private static final class FactoryBeanFallbackFeignFallback implements FactoryBean<FactoryBeanFallbackFeign> {
 
 		@Override
 		public FactoryBeanFallbackFeign getObject() {
@@ -124,7 +124,7 @@ public Class<?> getObjectType() {
 
 	}
 
-	private static class OriginalFeignFallback implements OriginalFeign {
+	private static final class OriginalFeignFallback implements OriginalFeign {
 
 		@Override
 		public String get() {
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClientTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/loadbalancer/FeignBlockingLoadBalancerClientTests.java
@@ -261,7 +261,7 @@ protected String getName() {
 
 	}
 
-	private static class InstanceIdTransformer implements LoadBalancerFeignRequestTransformer {
+	private static final class InstanceIdTransformer implements LoadBalancerFeignRequestTransformer {
 
 		@Override
 		public Request transformRequest(Request request, ServiceInstance instance) {
@@ -273,7 +273,7 @@ public Request transformRequest(Request request, ServiceInstance instance) {
 
 	}
 
-	private static class ServiceIdTransformer implements LoadBalancerFeignRequestTransformer {
+	private static final class ServiceIdTransformer implements LoadBalancerFeignRequestTransformer {
 
 		@Override
 		public Request transformRequest(Request request, ServiceInstance instance) {
diff --git a/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/loadbalancer/RetryableFeignBlockingLoadBalancerClientTests.java b/spring-cloud-openfeign-core/src/test/java/org/springframework/cloud/openfeign/loadbalancer/RetryableFeignBlockingLoadBalancerClientTests.java
@@ -376,7 +376,7 @@ protected String getName() {
 
 	}
 
-	private static class InstanceIdTransformer implements LoadBalancerFeignRequestTransformer {
+	private static final class InstanceIdTransformer implements LoadBalancerFeignRequestTransformer {
 
 		@Override
 		public Request transformRequest(Request request, ServiceInstance instance) {
@@ -388,7 +388,7 @@ public Request transformRequest(Request request, ServiceInstance instance) {
 
 	}
 
-	private static class ServiceIdTransformer implements LoadBalancerFeignRequestTransformer {
+	private static final class ServiceIdTransformer implements LoadBalancerFeignRequestTransformer {
 
 		@Override
 		public Request transformRequest(Request request, ServiceInstance instance) {

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ interface NoInheritFeignClient {`
`165`	`165`
`166`	`166`	`}`
`167`	`167`
`168`		`- private static class NoOpCapability implements Capability {`
	`168`	`+ private static final class NoOpCapability implements Capability {`
`169`	`169`
`170`	`170`	`}`
`171`	`171`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public Capability noOpCapability() {`
`117`	`117`
`118`	`118`	`}`
`119`	`119`
`120`		`- private static class NoOpCapability implements Capability {`
	`120`	`+ private static final class NoOpCapability implements Capability {`
`121`	`121`
`122`	`122`	`}`
`123`	`123`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public Capability noOpCapability() {`
`112`	`112`
`113`	`113`	`}`
`114`	`114`
`115`		`- private static class NoOpCapability implements Capability {`
	`115`	`+ private static final class NoOpCapability implements Capability {`
`116`	`116`
`117`	`117`	`}`
`118`	`118`
Original file line number	Diff line number	Diff line change
`@@ -326,11 +326,11 @@ private static class TestMicrometerObservationCapability extends feign.micromete`
`326`	`326`
`327`	`327`	`}`
`328`	`328`
`329`		`- private static class TestMicrometerCapability extends feign.micrometer.MicrometerCapability {`
	`329`	`+ private static final class TestMicrometerCapability extends feign.micrometer.MicrometerCapability {`
`330`	`330`
`331`	`331`	`}`
`332`	`332`
`333`		`- private static class NoOpCapability implements Capability {`
	`333`	`+ private static final class NoOpCapability implements Capability {`
`334`	`334`
`335`	`335`	`}`
`336`	`336`
Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ public void encode(Object o, Type type, RequestTemplate requestTemplate) throws`
`475`	`475`
`476`	`476`	`}`
`477`	`477`
`478`		`- public static class NoOpCapability implements Capability {`
	`478`	`+ public static final class NoOpCapability implements Capability {`
`479`	`479`
`480`	`480`	`}`
`481`	`481`
Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ interface NoInheritFeignClient {`
`172`	`172`
`173`	`173`	`}`
`174`	`174`
`175`		`- private static class NoOpCapability implements Capability {`
	`175`	`+ private static final class NoOpCapability implements Capability {`
`176`	`176`
`177`	`177`	`}`
`178`	`178`
Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ void shouldRunFallbackFromBeanOrFactoryBean() {`
`90`	`90`	`@EnableFeignClients(clients = { FallbackSupportFactoryBeanTests.OriginalFeign.class,`
`91`	`91`	`FallbackSupportFactoryBeanTests.FactoryBeanFallbackFeign.class })`
`92`	`92`	`@EnableAutoConfiguration`
`93`		`- private static class TestConfiguration {`
	`93`	`+ private static final class TestConfiguration {`
`94`	`94`
`95`	`95`	`}`
`96`	`96`
`@@ -110,7 +110,7 @@ interface FactoryBeanFallbackFeign {`
`110`	`110`
`111`	`111`	`}`
`112`	`112`
`113`		`- private static class FactoryBeanFallbackFeignFallback implements FactoryBean<FactoryBeanFallbackFeign> {`
	`113`	`+ private static final class FactoryBeanFallbackFeignFallback implements FactoryBean<FactoryBeanFallbackFeign> {`
`114`	`114`
`115`	`115`	`@Override`
`116`	`116`	`public FactoryBeanFallbackFeign getObject() {`
`@@ -124,7 +124,7 @@ public Class<?> getObjectType() {`
`124`	`124`
`125`	`125`	`}`
`126`	`126`
`127`		`- private static class OriginalFeignFallback implements OriginalFeign {`
	`127`	`+ private static final class OriginalFeignFallback implements OriginalFeign {`
`128`	`128`
`129`	`129`	`@Override`
`130`	`130`	`public String get() {`
Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ protected String getName() {`
`261`	`261`
`262`	`262`	`}`
`263`	`263`
`264`		`- private static class InstanceIdTransformer implements LoadBalancerFeignRequestTransformer {`
	`264`	`+ private static final class InstanceIdTransformer implements LoadBalancerFeignRequestTransformer {`
`265`	`265`
`266`	`266`	`@Override`
`267`	`267`	`public Request transformRequest(Request request, ServiceInstance instance) {`
`@@ -273,7 +273,7 @@ public Request transformRequest(Request request, ServiceInstance instance) {`
`273`	`273`
`274`	`274`	`}`
`275`	`275`
`276`		`- private static class ServiceIdTransformer implements LoadBalancerFeignRequestTransformer {`
	`276`	`+ private static final class ServiceIdTransformer implements LoadBalancerFeignRequestTransformer {`
`277`	`277`
`278`	`278`	`@Override`
`279`	`279`	`public Request transformRequest(Request request, ServiceInstance instance) {`
Original file line number	Diff line number	Diff line change
`@@ -376,7 +376,7 @@ protected String getName() {`
`376`	`376`
`377`	`377`	`}`
`378`	`378`
`379`		`- private static class InstanceIdTransformer implements LoadBalancerFeignRequestTransformer {`
	`379`	`+ private static final class InstanceIdTransformer implements LoadBalancerFeignRequestTransformer {`
`380`	`380`
`381`	`381`	`@Override`
`382`	`382`	`public Request transformRequest(Request request, ServiceInstance instance) {`
`@@ -388,7 +388,7 @@ public Request transformRequest(Request request, ServiceInstance instance) {`
`388`	`388`
`389`	`389`	`}`
`390`	`390`
`391`		`- private static class ServiceIdTransformer implements LoadBalancerFeignRequestTransformer {`
	`391`	`+ private static final class ServiceIdTransformer implements LoadBalancerFeignRequestTransformer {`
`392`	`392`
`393`	`393`	`@Override`
`394`	`394`	`public Request transformRequest(Request request, ServiceInstance instance) {`