fix: improve emoji actions and other chat popups #19362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caybro
requested review from
a team,
alexjba,
micieslak and
noeliaSD
as code owners
caybro
requested review from
jrainville and
vkjr
and removed request for
a team and
vkjr
caybro
commented
Nov 24, 2025
| function onEmojiSelected(emojiText: string, atCursor: bool) { | ||
| let emoji = StatusQUtils.Emoji.deparse(emojiText) | ||
| popup.contentItem.accountNameInput.input.asset.emoji = emoji | ||
| popup.contentItem.accountNameInput.input.asset.emoji = emojiText |
Member
Author
There was a problem hiding this comment.
Fixes changing a wallet account emoji
caybro
commented
Nov 24, 2025
| spacing: Theme.padding | ||
|
|
||
| StatusBaseText { | ||
| Layout.preferredWidth: parent.width - betaTag.width - parent.spacing |
caybro
commented
Nov 24, 2025
| return qsTr("%1 reacted with %2") | ||
| .arg(author) | ||
| .arg(StatusQUtils.Emoji.fromCodePoint(emoji)); | ||
| const author = Qt.locale(Qt.uiLanguage).createSeparatedList(listOfUsers) // "a, b, c and d" |
Member
Author
There was a problem hiding this comment.
https://doc.qt.io/qt-6/qlocale.html#createSeparatedList can do a much better job than the custom JS code clutch :)
caybro
commented
Nov 24, 2025
| readOnly: true | ||
| selectByMouse: true | ||
| selectByMouse: true // applies to mouse only, not touch | ||
| enabled: !Utils.isMobile // eats the touch events, thus breaking the context menu since this is an edit (albeit readonly) |
Member
Author
There was a problem hiding this comment.
Visually this is identical but has to be done because we abuse an edit control to display a piece of text
caybro
commented
Nov 24, 2025
| readonly property var format: { | ||
| "png": "png", | ||
| "svg": "svg" | ||
| } |
Member
Author
There was a problem hiding this comment.
Unused; we support and ship SVG only anyway
caybro
commented
Nov 24, 2025
| signal hoverChanged(bool hovered) | ||
| signal toggleReaction(string hexcode) | ||
|
|
||
| property bool isCurrentUser |
Member
Jenkins BuildsClick to see older builds (83)
|
anastasiyaig
requested review from
anastasiyaig
and removed request for
a team
jrainville
approved these changes
Nov 24, 2025
| } | ||
| } | ||
|
|
||
| // TODO remove me completely? literally the same as MessageContextMenuView, and overlaps the message text |
Member
There was a problem hiding this comment.
I personally like it on Desktop, it's faster to reply for example (one less click 😄 )
Member
Author
There was a problem hiding this comment.
True but with one line messages, the hover actions always cover half of the text
alexjba
approved these changes
Nov 24, 2025
caybro
force-pushed
the
fix/19328-19327-chat-context-menus-and-emojis
branch
3 times, most recently
from
b8593e8 to
0854840
Compare
caybro
force-pushed
the
fix/19328-19327-chat-context-menus-and-emojis
branch
from
0854840 to
0eaf680
Compare
- StatusMessageEmojiReactions: update according to the latest Figma designs, simplify the `showReactionAuthors()` function - StatusMessage: disable the hover quick actions on mobile; the context menu works much better and has the same actions (including the emoji quick reactions) - StatusTextMessage: make it `enabled: false` in order to support the long-press context menu on mobile - MessageView: streamline context menus opening that works with both mouse and touch - WalletAccountHeader: support fallback account icons (non-emojis) - RenameAccountModal: fix changing the emoji of an existing wallet account - removed some unused properties - update and fixed the relevant SB pages - do no use hardcoded margins/paddings - fix some QML warnings Fixes #19328 Fixes #19327 Iterates: #19199
caybro
force-pushed
the
fix/19328-19327-chat-context-menus-and-emojis
branch
2 times, most recently
from
9ed333c to
565b74f
Compare
- use StatusTextArea for StatusTextMessage; need this for the context menu on mobile - rework the context menu to ContextMenu + pressAndHold handler (the only combo that works on mobile) - use edge-to-edge separators in the profile context menu
caybro
force-pushed
the
fix/19328-19327-chat-context-menus-and-emojis
branch
from
565b74f to
f2a0cac
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
showReactionAuthors()functionenabled: falsein order to support the long-press context menu on mobileFixes #19328
Fixes #19327
Iterates: #19199
BACKPORT_TO: 2.36
Affected areas
Messaging, Account edit
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Emoji reactions:
Mobile screens TBD
Impact on end user
More consistent emojis behavior, improved esp. on mobile
How to test
Risk