chore: remove await_signals from tests

Author: igor-sirotin

tests-functional/clients/status_backend.py

@@ -39,7 +39,7 @@
 class StatusBackend(RpcClient, SignalClient, ApiClient):
     container = None
 
-    def __init__(self, await_signals=[], privileged=False, ipv6=USE_IPV6, **kwargs):
+    def __init__(self, privileged=False, ipv6=USE_IPV6, **kwargs):
         self.temp_dir = None
         self.ipv6 = True if ipv6 == "Yes" else False
         logging.debug(f"Flag USE_IPV6 is: {self.ipv6}")
@@ -83,7 +83,7 @@ def __init__(self, await_signals=[], privileged=False, ipv6=USE_IPV6, **kwargs):
 
         RpcClient.__init__(self)
         ApiClient.__init__(self, self.api_url)
-        SignalClient.__init__(self, self.ws_url, await_signals)
+        SignalClient.__init__(self, self.ws_url)
 
         self.wait_for_healthy()
 

tests-functional/steps/messenger.py

@@ -15,13 +15,6 @@
 
 class MessengerSteps(NetworkConditionsSteps):
 
-    await_signals = [
-        SignalType.MESSAGES_NEW.value,
-        SignalType.MESSAGE_DELIVERED.value,
-        SignalType.NODE_LOGIN.value,
-        SignalType.NODE_STOPPED.value,
-    ]
-
     def send_contact_request_and_wait_for_signal_to_be_received(self, sender=None, receiver=None) -> str:
         """
         Send a contact request from sender to receiver and wait for confirmation.

tests-functional/tests/benchmark/test_basic_benchmark.py

@@ -1,7 +1,6 @@
 import pytest
 import time
 
-from clients.signals import SignalType
 from clients.status_backend import StatusBackend
 from utils.config import Config
 from steps.messenger import MessengerSteps
@@ -15,13 +14,6 @@ class TestBasicBenchmark(MessengerSteps):
     This test suite contains a few test cases that track CPU, RAM and network usage via Docker API.
     """
 
-    await_signals = [
-        SignalType.MESSAGES_NEW.value,
-        SignalType.MESSAGE_DELIVERED.value,
-        SignalType.NODE_LOGIN.value,
-        SignalType.NODE_STOPPED.value,
-    ]
-
     @pytest.fixture(scope="function", autouse=False)
     def aut(self, request, backend_factory, waku_light_client):
         """Creates a AUT (Application Under Test) - a StatusBackend instance initialized for performance testing."""

tests-functional/tests/conftest.py

@@ -30,9 +30,6 @@ def test_with_params(self, backend_factory):
         self.receiver = backend_factory("receiver")
     """
 
-    # Get class-level configuration
-    await_signals = getattr(request.cls, "await_signals", ["messages.new", "message.delivered", "node.login", "node.logout"])
-
     # Get parameters from request.param if available
     params = getattr(request, "param", {})
 
@@ -61,7 +58,7 @@ def factory(name, **kwargs) -> StatusBackend:
         logging.debug(f"📋 [SETUP] Parameters: privileged={privileged}, ipv6={ipv6}")
 
         # Create backend
-        backend = StatusBackend(await_signals=await_signals, privileged=privileged, ipv6=ipv6, **kwargs)
+        backend = StatusBackend(privileged=privileged, ipv6=ipv6, **kwargs)
         created_backends.append(backend)
         logging.debug(f"✅ [SETUP] {name.capitalize()} backend created")
 

tests-functional/tests/test_backup_mnemonic_and_restore.py

@@ -14,22 +14,14 @@
 @pytest.mark.rpc
 class TestBackupMnemonicAndRestore:
 
-    await_signals = [
-        SignalType.MEDIASERVER_STARTED.value,
-        SignalType.NODE_STARTED.value,
-        SignalType.NODE_READY.value,
-        SignalType.NODE_LOGIN.value,
-        SignalType.NODE_STOPPED.value,
-    ]
-
     @pytest.fixture(autouse=True)
     def setup_cleanup(self, close_status_backend_containers):
         """Automatically cleanup containers after each test"""
         yield
 
     def test_profile_creation_and_mnemonics_backup(self):
         # Create a new account container and initialize
-        account = StatusBackend(self.await_signals)
+        account = StatusBackend()
         account.init_status_backend()
         account.create_account_and_login()
         account.wait_for_login()
@@ -43,7 +35,7 @@ def test_profile_creation_and_mnemonics_backup(self):
 
     def test_backup_account_and_restore_it_via_mnemonics(self):
         # Create original account and backup mnemonic
-        original_account = StatusBackend(self.await_signals)
+        original_account = StatusBackend()
         original_account.init_status_backend()
         original_account.create_account_and_login()
         original_account.wait_for_login()
@@ -56,7 +48,7 @@ def test_backup_account_and_restore_it_via_mnemonics(self):
         user.passphrase = mnemonic
 
         # Restore account in a new container
-        restored_account = StatusBackend(self.await_signals)
+        restored_account = StatusBackend()
         restored_account.init_status_backend()
         restored_account.restore_account_and_login(user=user)
         restored_account.wait_for_login()
@@ -90,7 +82,7 @@ def test_backup_account_and_restore_it_via_mnemonics(self):
     )
     def test_restore_app_different_valid_size_mnemonics(self, user_mnemonic):
         # Initialize backend client and restore account using user_mnemonic.
-        restored_account = StatusBackend(self.await_signals)
+        restored_account = StatusBackend()
         restored_account.init_status_backend()
         restored_account.restore_account_and_login(user=user_mnemonic)
         restored_account.wait_for_login()
@@ -116,7 +108,7 @@ def test_restore_with_arbitrary_size_mnemonics(self, mnemonic_size):
         user = copy.deepcopy(user_mnemonic_12)
         user.passphrase = " ".join("".join(random.choice(string.ascii_lowercase) for _ in range(random.randint(2, 10))) for _ in range(mnemonic_size))
 
-        restored_account = StatusBackend(self.await_signals)
+        restored_account = StatusBackend()
         restored_account.init_status_backend()
         restored_account.restore_account_and_login(user=user)
         restored_account.wait_for_login()
@@ -131,7 +123,7 @@ def test_restore_with_mnemonic_with_special_chars(self):
         user = copy.deepcopy(user_mnemonic_12)
         user.passphrase = "<>?`~!@#$%^&*()_+1 $fgdg ^&*()"
 
-        restored_account = StatusBackend(self.await_signals)
+        restored_account = StatusBackend()
         restored_account.init_status_backend()
         restored_account.restore_account_and_login(user=user)
         restored_account.wait_for_login()
@@ -144,7 +136,7 @@ def test_restore_with_empty_mnemonic(self):
         # Restore with empty mnemonic isn't allowed
         user = copy.deepcopy(user_mnemonic_12)
 
-        restored_account = StatusBackend(self.await_signals)
+        restored_account = StatusBackend()
         restored_account.init_status_backend()
         restored_account._set_display_name()
         data = restored_account._create_account_request(user)
@@ -155,7 +147,7 @@ def test_restore_with_empty_mnemonic(self):
     def test_restore_with_both_mnemonic_and_keycard(self):
         # Restore with both keycard and mnemonic isn't allowed
         user = copy.deepcopy(user_mnemonic_12)
-        restored_account = StatusBackend(self.await_signals)
+        restored_account = StatusBackend()
         restored_account.init_status_backend()
         restored_account._set_display_name()
         data = restored_account._create_account_request(user)
@@ -166,7 +158,7 @@ def test_restore_with_both_mnemonic_and_keycard(self):
 
     def test_restored_on_existing_restored_account_fails(self):
         user = copy.deepcopy(user_mnemonic_12)
-        restored_account = StatusBackend(self.await_signals)
+        restored_account = StatusBackend()
         restored_account.init_status_backend()
         restored_account.restore_account_and_login(user=user)
         restored_account.wait_for_login()

tests-functional/tests/test_edit_community.py

@@ -48,12 +48,6 @@ def validate_community_images(community, name, cert_file_path):
 @pytest.mark.rpc
 @pytest.mark.create_account
 class TestEditCommunity:
-    await_signals = [
-        SignalType.MEDIASERVER_STARTED.value,
-        SignalType.NODE_STARTED.value,
-        SignalType.NODE_READY.value,
-        SignalType.NODE_LOGIN.value,
-    ]
 
     @pytest.fixture()
     def backend(self, backend_new_profile) -> StatusBackend:

tests-functional/tests/test_eth_api.py

@@ -1,21 +1,12 @@
 import pytest
 
-from clients.signals import SignalType
 from resources.constants import user_1, user_2
 
 
 @pytest.mark.rpc
 @pytest.mark.ethclient
 @pytest.mark.xdist_group(name="Eth")
 class TestEth:
-    await_signals = [
-        SignalType.NODE_LOGIN.value,
-        SignalType.WALLET.value,
-        SignalType.WALLET_SUGGESTED_ROUTES.value,
-        SignalType.WALLET_ROUTER_SIGN_TRANSACTIONS.value,
-        SignalType.WALLET_ROUTER_SENDING_TRANSACTIONS_STARTED.value,
-        SignalType.WALLET_ROUTER_TRANSACTIONS_SENT.value,
-    ]
 
     def test_estimate_gas(self, backend_recovered_profile):
         backend = backend_recovered_profile("sender", user=user_1)

tests-functional/tests/test_init_status_app.py

@@ -1,9 +1,9 @@
 import logging
+import os
 
-from clients.status_backend import StatusBackend
 import pytest
-from clients.signals import SignalType
-import os
+
+from clients.status_backend import StatusBackend
 
 
 @pytest.mark.create_account
@@ -18,14 +18,7 @@ def setup_cleanup(self, close_status_backend_containers):
     @pytest.mark.init
     def test_init_app(self):
 
-        await_signals = [
-            SignalType.MEDIASERVER_STARTED.value,
-            SignalType.NODE_STARTED.value,
-            SignalType.NODE_READY.value,
-            SignalType.NODE_LOGIN.value,
-        ]
-
-        backend_client = StatusBackend(await_signals)
+        backend_client = StatusBackend()
         backend_client.init_status_backend()
         backend_client.restore_account_and_login()
 

tests-functional/tests/test_local_backup.py

@@ -15,14 +15,7 @@ class TestLocalBackup:
 
     @pytest.mark.init
     def test_local_backup(self, tmp_path):
-        await_signals = [
-            "mediaserver.started",
-            "node.started",
-            "node.ready",
-            "node.login",
-        ]
-
-        backend_client = StatusBackend(await_signals)
+        backend_client = StatusBackend()
         assert backend_client is not None
 
         # Init and login
@@ -211,7 +204,7 @@ def test_local_backup(self, tmp_path):
         assert backup_file is not None
 
         # Create a new installation
-        backend_client2 = StatusBackend(await_signals)
+        backend_client2 = StatusBackend()
         assert backend_client2 is not None
 
         # Init and login
@@ -294,13 +287,7 @@ def test_local_backup(self, tmp_path):
         assert one_on_one_chat_recovered, "One-to-one chat was not restored correctly"
 
     def test_local_backup_backwards_compatibility(self, tmp_path):
-        await_signals = [
-            "mediaserver.started",
-            "node.started",
-            "node.ready",
-            "node.login",
-        ]
-        backend_client = StatusBackend(await_signals)
+        backend_client = StatusBackend()
         assert backend_client is not None
         # Restore the account with a hardcoded mnemonic to get the same private key
         backend_client.init_status_backend()

tests-functional/tests/test_local_pairing.py

@@ -1,12 +1,14 @@
 import re
+
 import pytest
+
 from clients.api import ApiResponseError
 from clients.services.wakuext import ActivityCenterNotificationType, ContactRequestState
 from clients.signals import SignalType, LocalPairingEventType, LocalPairingEventAction
 from clients.status_backend import StatusBackend
 from resources.constants import Account
-from steps.messenger import MessengerSteps
 from resources.enums import MessageContentType
+from steps.messenger import MessengerSteps
 
 
 def check_server_sender_events(events):
@@ -153,21 +155,13 @@ def login_paired_device(backend: StatusBackend, key_uid, password):
 @pytest.mark.rpc
 class TestLocalPairing(MessengerSteps):
 
-    await_signals = [
-        SignalType.MESSAGES_NEW.value,
-        SignalType.MESSAGE_DELIVERED.value,
-        SignalType.NODE_LOGIN.value,
-        SignalType.NODE_STOPPED.value,
-        SignalType.LOCAL_PAIRING.value,
-    ]
-
     @pytest.fixture(autouse=True)
     def setup_cleanup(self, close_status_backend_containers):
         """Automatically cleanup containers after each test"""
         yield
 
-    def initialize_backend(self, await_signals, privileged=True, **kwargs):
-        backend = StatusBackend(await_signals, privileged=privileged)
+    def initialize_backend(self, privileged=True, **kwargs):
+        backend = StatusBackend(privileged=privileged)
         backend.init_status_backend()
         backend.create_account_and_login(**kwargs)
         backend.wait_for_login()
@@ -176,10 +170,10 @@ def initialize_backend(self, await_signals, privileged=True, **kwargs):
 
     def test_pairing_server_as_sender(self):
         # Create users
-        alice = self.initialize_backend(self.await_signals, False)
-        bob = self.initialize_backend(self.await_signals, False)
+        alice = self.initialize_backend(False)
+        bob = self.initialize_backend(False)
 
-        bob_second_device = StatusBackend(self.await_signals)
+        bob_second_device = StatusBackend()
         bob_second_device.init_status_backend()
 
         # Make contacts before local pairing
@@ -257,9 +251,9 @@ def test_pairing_server_as_sender(self):
 
     def test_pairing_server_as_receiver(self):
         # Create users
-        alice = self.initialize_backend(self.await_signals, False)
-        bob = self.initialize_backend(self.await_signals, False)
-        bob_second_device = StatusBackend(self.await_signals)
+        alice = self.initialize_backend(False)
+        bob = self.initialize_backend(False)
+        bob_second_device = StatusBackend()
         bob_second_device.init_status_backend()
 
         # Make contacts before local pairing
@@ -301,14 +295,14 @@ def test_pairing_server_as_receiver(self):
 
     def test_pairing_three_devices(self):
         # Create users
-        bob1 = self.initialize_backend(self.await_signals, False)
-        bob2 = StatusBackend(self.await_signals)
+        bob1 = self.initialize_backend(False)
+        bob2 = StatusBackend()
         bob2.init_status_backend()
-        bob3 = StatusBackend(self.await_signals)
+        bob3 = StatusBackend()
         bob3.init_status_backend()
-        user_accepted = self.initialize_backend(self.await_signals, False)
-        user_pending = self.initialize_backend(self.await_signals, False)
-        user_declined = self.initialize_backend(self.await_signals, False)
+        user_accepted = self.initialize_backend(False)
+        user_pending = self.initialize_backend(False)
+        user_declined = self.initialize_backend(False)
 
         # Setup contacts before local pairing
         self.make_contacts(user_accepted, bob1)
@@ -356,8 +350,8 @@ def test_pairing_three_devices(self):
             assert user_declined_notification["dismissed"] is True
 
     def test_pairing_receiver_must_be_logged_out(self):
-        sender = self.initialize_backend(self.await_signals, False)
-        receiver = self.initialize_backend(self.await_signals, False)
+        sender = self.initialize_backend(False)
+        receiver = self.initialize_backend(False)
 
         # Client receiver must be logged out
         connection_string = sender.get_connection_string_for_bootstrapping_another_device()