chore: stop vendoring #6951
Open
chore: stop vendoring #6951
+38
−5,776,042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (120)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6951 +/- ##
===========================================
+ Coverage 59.58% 59.63% +0.04%
===========================================
Files 801 801
Lines 113885 113885
===========================================
+ Hits 67864 67914 +50
+ Misses 39085 39053 -32
+ Partials 6936 6918 -18
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Sep 25, 2025
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
bcc7833 to
485d724
Compare
Collaborator
Author
|
@status-im/devops guys can you please assist me with |
igor-sirotin
force-pushed
the
chore/nwaku-submodule
branch
from
06d4055 to
3564b77
Compare
igor-sirotin
changed the base branch from
chore/nwaku-submodule
to
feat/bump-waku-go-bindings
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
dde9a6b to
c61255e
Compare
Member
|
The trick is actually that # The SRI hash of the vendored dependencies.
# If `vendorHash` is `null`, no dependencies are fetched and
# the build relies on the vendor folder within the source.
vendorHash ? throw (
if args ? vendorSha256 then
"buildGoModule: Expect vendorHash instead of vendorSha256"
else
"buildGoModule: vendorHash is missing"
),So from now on we need to specify a real hash. Which means it will have to be updated every time dependencies change. |
Collaborator
Author
Thanks for fixing this.
@jakubgs is there any chance we can avoid this? It's gonna be quite an annoying procedure 😄 |
Member
|
I know of no built-in way of doing this. The purpose of We'd have to write some kind of script to generate the hash for us, but it would have to be committed anyway by the devs. |
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
b4cc062 to
daa5f1a
Compare
igor-sirotin
changed the base branch from
feat/bump-waku-go-bindings
to
feat/external-nwaku
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
daa5f1a to
92c8018
Compare
igor-sirotin
force-pushed
the
feat/external-nwaku
branch
from
9751a7d to
8dbdbca
Compare
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
f824870 to
d1d2aec
Compare
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
2 times, most recently
from
c9a2aac to
d06b803
Compare
igor-sirotin
changed the base branch from
develop
to
feat/external-goroutine-defer-guard
Collaborator
Author
|
|
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
d06b803 to
ab382cb
Compare
igor-sirotin
force-pushed
the
feat/external-goroutine-defer-guard
branch
from
eb76550 to
d0edf2d
Compare
Base automatically changed from
feat/external-goroutine-defer-guard
to
develop
November 5, 2025 16:31
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
ab382cb to
e08b53b
Compare
ci: update github pr workflow chore: update nix vendor hash
igor-sirotin
force-pushed
the
chore/stop-vendoring
branch
from
e08b53b to
a097641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
Description
Stop vendoring Go dependencies. Delete
vendor/directory.Reasoning
As for today, vendoring dependencies in Go is more of a burden than real need.
Major Go projects like
go-ethereumdon't vendor.The only reason for vendoring is to have all dependencies on hands in case one of them is suddenly becomes unavailable
(deleted of removed from public). On the other hand, it makes the repo heavier and PRs less clear, which we believe is more important. This becomes more obvious with the usage of
go tool(e.g. in PRs like #6933).nixWith this change, developers will need to update this
vendorHashmanually:status-go/nix/pkgs/status-go/library/default.nix
Line 14 in ae5ed83
I implemented
make vendortarget for this:status-go/Makefile
Lines 404 to 412 in 33218c6