Status go codex integration lib #7056
Draft
+4,647
−580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oining the community
Member
Jenkins BuildsClick to see older builds (270)
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## status-go-codex-integraion-arnaud #7056 +/- ##
=====================================================================
+ Coverage 49.92% 50.61% +0.68%
=====================================================================
Files 810 810
Lines 115612 116357 +745
=====================================================================
+ Hits 57725 58899 +1174
+ Misses 51946 51371 -575
- Partials 5941 6087 +146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
marcinczenko
force-pushed
the
status-go-codex-integraion-arnaud
branch
from
d8d05ab to
5761ad4
Compare
|
Thank you for opening this pull request! We require pull request titles and commits to follow the Conventional Commits specification and it looks like your PR needs to be adjusted. Details:
Available types:
|
Changes RPC call wakuext_UpdateMessageArchiveInterval to accept seconds instead of nanoseconds.
…AndSeedHistoryArchive
…king for chat id filters
emizzle
reviewed
Nov 9, 2025
| assert member_msgs_resp.get("messages")[0].get("text") == text | ||
|
|
||
| # Just make sure that archive are generated | ||
| time.sleep(10) |
Contributor
There was a problem hiding this comment.
Might be a good idea to pull this out into a variable, so that a change in the
profile message_archive_interval=10 setting does not cause the test to fail in
an odd way. It also self-describes the reason for sleeping here.
emizzle
reviewed
Nov 9, 2025
| assert member_msgs_resp.get("messages") is None, "Another member should not have messages before archive is dispatched" | ||
|
|
||
| # Ensure that the another member received the archive dispatch message | ||
| time.sleep(5) |
Contributor
There was a problem hiding this comment.
Same here. This would be a self-describing sleep if there was a global variable for import_initial_delay.
…mall improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final touches to the status-go codex integration with libcodex.