Remote-User header #43
Replies: 5 comments 8 replies
-
|
Hello, I would happily approve a pull request! This looks interesting as a lot of similar projects do the same so it would be a nice addition for tinyauth. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @steveiliop56 ! Thanks for accepting my PR ! I am a bit concerned about the name you chose for the header. The name X-Tinyauth-User is a custom one and do not respect the RFC 3875 as mentionned here : Firefly-III Docs. The same header (Remote-User) is also used in Django. It can be changed with some trickery : you install the header transformer plugin for traefik, but it involves too much config for my taste (but it was what i did when i was using Oauth2-proxy). What do you think about implementing a config in your project to customize the header name with an env var, check what i did in my fork : main...WilliamB78:tinyauth:main Thanks again for the project and your time ! |
Beta Was this translation helpful? Give feedback.
-
|
Hello, I was mostly inspired by |
Beta Was this translation helpful? Give feedback.
-
|
This has been working wonderfully so far, thank you for implementing this 🙂 One thing I noticed is when using OAuth to sign in, the Since the Basically:
If this isn't an option in Tinyauth, could this be achievable externally through something like Caddy? |
Beta Was this translation helpful? Give feedback.
-
|
Ya'll seem to understand this stuff better than I do! I've configured tinyauth with Microsoft OAuth. I can login just fine - the integration works. I'm using caddy, and I've tried: I've also tried And a number of other combinations, but nothing seems to work Redacted and change some info for privacy reasons, but not sure how I can pass in this info. docker-compose.yml |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello !!
First of all, thanks for this project, and also well done !
I am currently testing it in place of oauth2-proxy in my homelab, and so far so good !
As the title mentions, I am wondering if you'd take a PR to add the Remote-User header, i simply added it and it works well for my configuration (Generic Oauth with Zitadel, Remote-User added to traefik authresponseheader), but i don't know how it works with github or google !
Check this out : WilliamB78@1aa9dda
And tell me what you think of this !
Thanks :)
Beta Was this translation helpful? Give feedback.
All reactions