Skip to content

Commit 7765294

Browse files
sugyanclaude
andauthored
Fix release workflow draft handling and npm OIDC authentication (#274)
* Fix release workflow to properly handle draft releases - Split release creation into two steps to avoid immutable release error - Step 1: Upload assets to draft release (draft: true) - Step 2: Publish release without touching assets (draft: false) - Resolves softprops/action-gh-release#653 issue with immutable releases This ensures: 1. tagpr creates draft release correctly 2. Assets are uploaded to mutable draft release 3. Release is published only after assets are uploaded 4. No "Cannot upload assets to immutable release" errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * Update npm to latest version for OIDC Trusted Publishers support - Add npm update step to npm-publish job before dependencies installation - Node.js 22 ships with npm 10.9.3, but OIDC Trusted Publishers requires npm 11.5.1+ - This ensures npm CLI can detect and use OIDC authentication properly - Enables automatic provenance attestations for enhanced supply chain security Combined with previous draft release workflow fix, this should resolve: 1. "Cannot upload assets to immutable release" error (draft handling) 2. npm publish authentication failures (npm version requirement) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
1 parent 25e84c6 commit 7765294

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

.github/workflows/release.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,18 @@ jobs:
122122
with:
123123
path: ./artifacts
124124

125-
- name: Create release
125+
- name: Upload release assets
126126
uses: softprops/action-gh-release@v2
127127
with:
128128
files: |
129129
artifacts/*/*
130130
frontend/demo-recordings/*.webm
131+
draft: true
132+
prerelease: false
133+
134+
- name: Publish release
135+
uses: softprops/action-gh-release@v2
136+
with:
131137
generate_release_notes: true
132138
draft: false
133139
prerelease: false
@@ -152,6 +158,9 @@ jobs:
152158
backend/package-lock.json
153159
frontend/package-lock.json
154160
161+
- name: Update npm to latest version
162+
run: npm install -g npm@latest
163+
155164
- name: Install backend dependencies
156165
run: npm ci
157166
working-directory: backend

0 commit comments

Comments
 (0)