Skip to content

Conversation

@dwrobel
Copy link
Contributor

@dwrobel dwrobel commented Jun 27, 2025

No description provided.

@dwrobel
Copy link
Contributor Author

dwrobel commented Jun 27, 2025

I assumed heuristically en_US language.

@s-hadinger
Copy link
Collaborator

Thanks, yes we assume en_US.

I'm ok with most changes except:

  • "filesystem" instead of "Filesystem" - I don't understand why you capitalized it
  • "Zigbee" instead of "ZigBee" - the camel case here is ugly and quite uncommon

Can you please change accordingly?

@dwrobel dwrobel force-pushed the Fix-some-typos-in-Berry.md branch from 7f6834c to 34aef06 Compare June 30, 2025 07:49
@dwrobel
Copy link
Contributor Author

dwrobel commented Jun 30, 2025

* "filesystem" instead of "Filesystem" - I don't understand why you capitalized it

I named it after the section name:

$ git grep -e '#.*Filesystem' -- docs/Berry.md 
docs/Berry.md:## Loading Filesystem
$ git log -n1
commit a35f85e184315200a31f07447d7e7400ea92b1ac (HEAD -> master, origin/master, origin/HEAD)
Author: Stephan Hadinger <[email protected]>
Date:   Sun Jun 29 07:17:19 2025 +0000

    Update Berry short manual

@s-hadinger
Copy link
Collaborator

Yes, capitalization in titles is common, but I prefer to keep it lowercase in text.

@dwrobel dwrobel force-pushed the Fix-some-typos-in-Berry.md branch from 34aef06 to 4c73ac5 Compare June 30, 2025 11:11
@dwrobel
Copy link
Contributor Author

dwrobel commented Jun 30, 2025

I prefer to keep it lowercase in text.

PR has been updated accordingly.

@s-hadinger s-hadinger merged commit 33b0c04 into tasmota:master Jul 6, 2025
1 check passed
@s-hadinger
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants