chore: update mago and remove some flaky tests (#1579)

Author: innocenzi

composer.json

@@ -47,7 +47,7 @@
     "require-dev": {
         "aws/aws-sdk-php": "^3.338.0",
         "azure-oss/storage-blob-flysystem": "^1.2",
-        "carthage-software/mago": "^1.0.0-beta.16",
+        "carthage-software/mago": "1.0.0-beta.24",
         "guzzlehttp/psr7": "^2.6.1",
         "league/flysystem-aws-s3-v3": "^3.25.1",
         "league/flysystem-ftp": "^3.25.1",

mago.toml

@@ -35,7 +35,6 @@ empty-line-after-opening-tag = false
 integrations = ["php-unit", "tempest"]
 
 [linter.rules]
-yoda-conditions = { enabled = false }
 interface-name = { psr = false }
 trait-name = { psr = false }
 class-name = { psr = false }
@@ -62,6 +61,4 @@ halstead = { enabled = false }
 prefer-arrow-function = { enabled = false } # enable when references are fixed
 prefer-first-class-callable = { enabled = false } # enable when arguments are fixed
 strict-behavior = { allow-loose-behavior = true }
-
-# [analyzer]
-# override-attribute = { enabled = false } # CONSIDER ENABLING
+yoda-conditions = { enabled = false }

packages/cryptography/tests/TimelockTest.php

@@ -81,7 +81,7 @@ public function test_uses_clock_to_sleep(): void
 
         $elapsed = $clock->timestamp()->getMilliseconds() - $ms;
 
-        // Even if we mock the clock, there's a `microtime` call that may be off by a few ms on Windows
-        $this->assertEqualsToMoreOrLess(300, $elapsed, margin: 0, windowsMargin: 2);
+        // Even if we mock the clock, there's a `microtime` call that may be off by a few ms
+        $this->assertEqualsToMoreOrLess(300, $elapsed, margin: 2);
     }
 }

packages/support/src/Str/functions.php

@@ -51,6 +51,8 @@ function to_upper_case(Stringable|string $string): string
 
     /**
      * Converts the given string to snake case.
+     *
+     * @mago-expect lint:require-preg-quote-delimiter
      */
     function to_snake_case(Stringable|string $string, Stringable|string $delimiter = '_'): string
     {
@@ -63,7 +65,6 @@ function to_snake_case(Stringable|string $string, Stringable|string $delimiter =
 
         $string = preg_replace('/(?<=\p{Ll}|\p{N})(\p{Lu})/u', $delimiter . '$1', $string);
         $string = preg_replace('/(?<=\p{Lu})(\p{Lu}\p{Ll})/u', $delimiter . '$1', $string);
-        // @mago-expect lint:require-preg-quote-delimiter
         $string = preg_replace('![^' . preg_quote($delimiter) . '\pL\pN\s]+!u', $delimiter, mb_strtolower($string, 'UTF-8'));
         $string = preg_replace('/\s+/u', $delimiter, $string);
         $string = trim($string, $delimiter);

packages/support/tests/Random/FunctionsTest.php

@@ -96,7 +96,6 @@ public function test_is_ulid(): void
         $this->assertFalse(Random\is_ulid('0ec29141-3d58-4187-b664-2d93b7da0d31'));
         $this->assertFalse(Random\is_ulid('018dcc19-7e65-7c4b-9b14-9a11df3e0fdb'));
         $this->assertFalse(Random\is_ulid('foo'));
-        $this->assertFalse(Random\is_ulid(Random\secure_string(26)));
         $this->assertFalse(Random\is_ulid(null));
     }
 }

tests/Integration/Console/Components/TaskComponentTest.php

@@ -52,6 +52,8 @@ public function test_no_task(): void
 
     public function test_process_task(): void
     {
+        $this->skipCI('Flaky on CI');
+
         $this->console
             ->withoutPrompting()
             ->call(function (Console $console): void {
@@ -85,6 +87,8 @@ public function test_successful_task(): void
 
     public function test_failing_task(): void
     {
+        $this->skipCI('Flaky on CI');
+
         $this->console
             ->withoutPrompting()
             ->call(function (Console $console): void {