refactor: code quality updates (#1715)

Author: xHeaven

docs/0-getting-started/01-introduction.md

@@ -139,12 +139,12 @@ final readonly class BooksCommand
 Or what about [Tempest's ORM](../1-essentials/03-database), which aims to have truly decoupled models:
 
 ```php
-use Tempest\Validation\Rules\Length;
+use Tempest\Validation\Rules\HasLength;
 use App\Author;
 
 final class Book
 {
-    #[Length(min: 1, max: 120)]
+    #[HasLength(min: 1, max: 120)]
     public string $title;
 
     public ?Author $author = null;

docs/1-essentials/01-routing.md

@@ -344,13 +344,13 @@ A request class must implement {`Tempest\Http\Request`} and should use the {`Tem
 ```php app/RegisterAirportRequest.php
 use Tempest\Http\Request;
 use Tempest\Http\IsRequest;
-use Tempest\Validation\Rules\Length;
+use Tempest\Validation\Rules\HasLength;
 
 final class RegisterAirportRequest implements Request
 {
     use IsRequest;
 
-    #[Length(min: 10, max: 120)]
+    #[HasLength(min: 10, max: 120)]
     public string $name;
 
     public ?DateTimeImmutable $registeredAt = null;

packages/clock/src/MockClock.php

@@ -90,7 +90,7 @@ public function minus(int|Duration $duration): void
     /**
      * @mago-expect lint:no-debug-symbols
      */
-    public function dd(): void
+    public function dd(): never
     {
         dd($this->now);
     }

packages/database/src/QueryStatements/UpdateStatement.php

@@ -35,7 +35,7 @@ public function compile(DatabaseDialect $dialect): string
         }
 
         $query[] = 'SET ' . $this->values
-            ->map(fn (mixed $_, mixed $key) => sprintf("`{$key}` = ?"))
+            ->map(fn (mixed $_, mixed $key) => "`{$key}` = ?")
             ->implode(', ');
 
         if ($this->where->isNotEmpty()) {

packages/datetime/src/TemporalConvenienceMethods.php

@@ -561,7 +561,7 @@ public function __toString(): string
      * @phpstan-ignore disallowed.function
      * @mago-expect lint:no-debug-symbols
      */
-    public function dd(): void
+    public function dd(): never
     {
         dd($this);
     }

packages/debug/src/functions.php

@@ -21,7 +21,7 @@ function lw(mixed ...$input): void
          * Writes the given `$input` to the logs, dumps it, and stops the execution of the script.
          * @see \Tempest\Debug\Debug::log()
          */
-        function ld(mixed ...$input): void
+        function ld(mixed ...$input): never
         {
             Debug::resolve()->log($input);
             die();

packages/intl/src/MessageFormat/Formatter/MessageFormatter.php

@@ -57,7 +57,7 @@ public function format(string $message, mixed ...$variables): string
 
             $this->variables = $this->parseLocalVariables($variables);
 
-            return $this->formatMessage($ast, $variables);
+            return $this->formatMessage($ast);
         } catch (ParsingException $e) {
             throw new FormattingException('Failed to parse message.', [
                 'message' => $message,

packages/process/src/Testing/ProcessTester.php

@@ -107,7 +107,7 @@ public function disableProcessExecution(): void
      *
      * @mago-expect lint:no-debug-symbols
      */
-    public function debugExecutedProcesses(): void
+    public function debugExecutedProcesses(): never
     {
         dd($this->executor->executions);
     }

packages/support/src/Math/functions.php

@@ -380,7 +380,7 @@ function max(array $numbers): null|int|float
      */
     function maxva(int|float $first, int|float $second, int|float ...$rest): int|float
     {
-        $max = $first > $second ? $first : $second;
+        $max = \max($first, $second);
 
         foreach ($rest as $number) {
             if ($number > $max) {
@@ -512,7 +512,7 @@ function min(array $numbers): null|float|int
      */
     function minva(int|float $first, int|float $second, int|float ...$rest): int|float
     {
-        $min = $first < $second ? $first : $second;
+        $min = \min($first, $second);
 
         foreach ($rest as $number) {
             if ($number < $min) {

packages/support/src/Str/ManipulatesString.php

@@ -128,11 +128,11 @@ public function pluralize(int|array|Countable $count = 2): self
     /**
      * Converts the string to its English singular form.
      */
-    public function singularize(int|array|Countable $count = 2): self
+    public function singularize(): self
     {
         $this->ensurePluralizerInstalled(__METHOD__);
 
-        return $this->createOrModify(Intl\singularize($this->value, $count));
+        return $this->createOrModify(Intl\singularize($this->value));
     }
 
     /**