Skip to content

Conversation

@dandavison
Copy link
Contributor

@dandavison dandavison commented Jul 25, 2024

I only did this because I spotted one s/signal/update/ copy-paste error, but then I felt I should do a bit more editing to make the PR a more respectable size. The set of files looked at here is essentially random (they appeared close together in a file browser).


Note

Refines Javadocs across workflow dynamic handlers and package docs to mention updates and improve grammar, and fixes an error-message typo in ExternalWorkflowStub.

  • Docs/Javadocs
    • Clarify wording and grammar in DynamicQueryHandler, DynamicSignalHandler, DynamicUpdateHandler, and DynamicWorkflow (e.g., library-level phrasing, DSL description, and “updates” vs “signals”).
    • Update workflow/package-info.java to explicitly mention updates alongside signals and improve phrasing in multiple sections.
  • Bug Fix (typo)
    • Correct error message text in ExternalWorkflowStub#fromTyped ("sbub" → "stub") and minor grammar in class Javadoc.

Written by Cursor Bugbot for commit 2804423. This will update automatically on new commits. Configure here.

@dandavison dandavison requested a review from a team as a code owner July 25, 2024 12:30
@Quinn-With-Two-Ns
Copy link
Contributor

For CI to pass you need to rebase. Your code is to far behind the github actions

@dandavison dandavison force-pushed the docstrings-and-comments-1 branch 3 times, most recently from 96045ef to 5885943 Compare July 31, 2024 18:45
@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the docstrings-and-comments-1 branch from 5885943 to 2804423 Compare December 7, 2025 05:55
@dandavison dandavison merged commit f2fe3f5 into master Dec 8, 2025
18 checks passed
@dandavison
Copy link
Contributor Author

Sorry I forgot about this. I'll hit merge now because it's green and I think that was your intention and usually the author merges.

@dandavison dandavison deleted the docstrings-and-comments-1 branch December 8, 2025 00:16
@Quinn-With-Two-Ns
Copy link
Contributor

Yep, just cleaning up old open PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants