SQL non standard issues

[alelopezperez]

From what i've investigated it seems that there a some particularies in the serialization of a sql statement, that come into conflict with MySql(I'm developing support for MySql)

From what I gathered
1) Quoted table names from toasty/src/core/src/stm/sql/serialize.rs this is not supported in MySql FIXED

  fn ident_str(&mut self, ident: &str) -> fmt::Result {
        write!(self.dst, "\"{ident}\"")?;
        Ok(())
    }
}

2. Since toasty uses TEXT type for ID, in MySQL it should be sized
   CREATE TABLE users (id TEXT, name INTEGER, email TEXT, moto TEXT, PRIMARY KEY (id)); => ERROR 1170 (42000) at line 1: BLOB/TEXT column 'id' used in key specification without a key length

It should be something like this
CREATE TABLE usuarios (id TEXT, name INTEGER, email TEXT, moto TEXT, PRIMARY KEY (id(11)));

3. RETURNING clause in mysql only works for INSERT, DELETE and REPLACE but not for UPDATE
   medium_article_evidence
   stackoverflow_question
   mariadb_docs

[alelopezperez]

They are many more places were wrapping of table names occur, in toasty/src/core/src/stm/sql/serialize.rs from what i gathered are the select insert delete and update from impl<T: Params> Formatter<'_, T>

[carllerche]

Thanks. I recently refactored, which should make it easier to define per-db column types based on the specific database driver. Also, the SQL serializer intends to support configuration options to handle this kind of case. More work will probably be needed to support MySQL and other SQL divergences.

[alelopezperez]

Thanks for the clarification! I'll keep an eye on it and keep my branch updated

[carllerche]

Do you want to take a stab at fixing quoting in the serializer? Add some config options to the serializer struct and update the serialization code to respect them?

[alelopezperez]

I'm interested, Yes, let's start with quoiting of the tables names.