Merge #1623: Update dependencies and fix clippy errors

11721dc chore(deps): udpate dependencies (Jose Celano)
364c607 fix: clippy errors (Jose Celano)

Pull request description:

  Update dependencies and fix clippy errors.

  ```
  $ cargo update
      Updating crates.io index
       Locking 264 packages to latest compatible versions
      Updating addr2line v0.24.2 -> v0.25.1
      Updating aho-corasick v1.1.3 -> v1.1.4
        Adding alloca v0.4.0
      Removing android-tzdata v0.1.1
      Updating anstream v0.6.19 -> v0.6.21
      Updating anstyle v1.0.11 -> v1.0.13
      Updating anstyle-query v1.1.3 -> v1.1.5
      Updating anstyle-wincon v3.0.9 -> v3.0.11
      Updating anyhow v1.0.98 -> v1.0.100
        Adding astral-tokio-tar v0.5.6
      Updating async-channel v2.3.1 -> v2.5.0
      Updating async-compression v0.4.24 -> v0.4.34
      Updating async-executor v1.13.2 -> v1.13.3
      Updating async-io v2.4.1 -> v2.6.0
      Updating async-lock v3.4.0 -> v3.4.1
      Updating async-std v1.13.1 -> v1.13.2
        Adding async-stream v0.3.6
        Adding async-stream-impl v0.3.6
      Updating async-trait v0.1.88 -> v0.1.89
      Updating atomic v0.6.0 -> v0.6.1
      Updating autocfg v1.4.0 -> v1.5.0
      Updating axum v0.8.4 -> v0.8.7
      Updating axum-core v0.5.2 -> v0.5.5
      Updating axum-extra v0.10.1 -> v0.12.2
      Updating axum-server v0.7.2 -> v0.7.3
      Updating backtrace v0.3.75 -> v0.3.76
      Updating bigdecimal v0.4.8 -> v0.4.9
      Updating bindgen v0.72.0 -> v0.72.1
      Removing bitflags v1.3.2
      Removing bitflags v2.9.1
        Adding bitflags v2.10.0
      Updating blocking v1.6.1 -> v1.6.2
      Updating bollard v0.18.1 -> v0.19.4
        Adding bollard-buildkit-proto v0.7.0
      Updating bollard-stubs v1.47.1-rc.27.3.1 -> v1.49.1-rc.28.4.0
      Updating borsh v1.5.7 -> v1.6.0
      Updating borsh-derive v1.5.7 -> v1.6.0
      Updating brotli v8.0.1 -> v8.0.2
      Updating bumpalo v3.18.1 -> v3.19.0
      Updating bytemuck v1.23.1 -> v1.24.0
      Updating bytes v1.10.1 -> v1.11.0
      Updating camino v1.1.10 -> v1.1.12 (available: v1.2.1)
      Updating castaway v0.2.3 -> v0.2.4
      Updating cc v1.2.26 -> v1.2.48
      Updating cfg-if v1.0.1 -> v1.0.4
      Updating chrono v0.4.41 -> v0.4.42
      Updating clap v4.5.40 -> v4.5.53
      Updating clap_builder v4.5.40 -> v4.5.53
      Updating clap_derive v4.5.40 -> v4.5.49
      Updating clap_lex v0.7.5 -> v0.7.6
        Adding compression-codecs v0.4.33
        Adding compression-core v0.4.31
      Updating crc32fast v1.4.2 -> v1.5.0
      Updating criterion v0.6.0 -> v0.8.0
        Adding criterion-plot v0.8.0
      Updating crunchy v0.2.3 -> v0.2.4
      Updating crypto-common v0.1.6 -> v0.1.7
        Adding darling v0.21.3
        Adding darling_core v0.21.3
        Adding darling_macro v0.21.3
      Updating deranged v0.4.0 -> v0.5.5
        Adding dyn-clone v1.0.20
      Updating errno v0.3.12 -> v0.3.14
      Updating etcetera v0.10.0 -> v0.11.0
      Updating event-listener v5.4.0 -> v5.4.1
        Adding ferroid v0.8.7
      Updating filetime v0.2.25 -> v0.2.26
        Adding find-msvc-tools v0.1.5
      Updating flate2 v1.1.2 -> v1.1.5
      Updating form_urlencoded v1.2.1 -> v1.2.2
      Updating frunk v0.4.3 -> v0.4.4
      Updating frunk_core v0.4.3 -> v0.4.4
      Updating frunk_derives v0.4.3 -> v0.4.4
      Updating frunk_proc_macro_helpers v0.1.3 -> v0.1.4
      Updating frunk_proc_macros v0.1.3 -> v0.1.4
      Updating fs-err v3.1.1 -> v3.2.0
      Updating futures-lite v2.6.0 -> v2.6.1
      Updating getrandom v0.3.3 -> v0.3.4
      Updating gimli v0.31.1 -> v0.32.3
      Updating glob v0.3.2 -> v0.3.3
      Updating h2 v0.4.10 -> v0.4.12
      Updating half v2.6.0 -> v2.7.1
      Removing hashbrown v0.15.4
        Adding hashbrown v0.15.5
        Adding hashbrown v0.16.1
      Updating hermit-abi v0.5.1 -> v0.5.2
      Updating hex-literal v1.0.0 -> v1.1.0
      Updating home v0.5.11 -> v0.5.12
      Updating http v1.3.1 -> v1.4.0
      Updating hyper v1.6.0 -> v1.8.1
        Adding hyper-timeout v0.5.2
      Updating hyper-util v0.1.14 -> v0.1.18
      Updating iana-time-zone v0.1.63 -> v0.1.64
      Updating icu_collections v2.0.0 -> v2.1.1
      Updating icu_locale_core v2.0.0 -> v2.1.1
      Updating icu_normalizer v2.0.0 -> v2.1.1
      Updating icu_normalizer_data v2.0.0 -> v2.1.1
      Updating icu_properties v2.0.1 -> v2.1.1
      Updating icu_properties_data v2.0.1 -> v2.1.1
      Updating icu_provider v2.0.0 -> v2.1.1
      Updating idna v1.0.3 -> v1.1.0
      Updating indexmap v2.9.0 -> v2.12.1
      Updating iri-string v0.7.8 -> v0.7.9
      Updating is-terminal v0.4.16 -> v0.4.17
      Updating is_terminal_polyfill v1.70.1 -> v1.70.2
        Adding itertools v0.14.0
      Updating jobserver v0.1.33 -> v0.1.34
      Updating js-sys v0.3.77 -> v0.3.83
      Updating libc v0.2.172 -> v0.2.177
      Updating libloading v0.8.8 -> v0.8.9
      Updating libredox v0.1.3 -> v0.1.10
      Updating libsqlite3-sys v0.34.0 -> v0.35.0
      Updating libz-sys v1.1.22 -> v1.1.23
      Updating linux-raw-sys v0.9.4 -> v0.11.0
      Updating litemap v0.8.0 -> v0.8.1
      Updating lock_api v0.4.13 -> v0.4.14
      Updating log v0.4.27 -> v0.4.28
      Updating memchr v2.7.4 -> v2.7.6
      Updating mio v1.0.4 -> v1.1.0
      Updating mockall v0.13.1 -> v0.14.0
      Updating mockall_derive v0.13.1 -> v0.14.0
      Updating nu-ansi-term v0.46.0 -> v0.50.3
        Adding num v0.4.3
        Adding num-complex v0.4.6
        Adding num-iter v0.1.45
        Adding num-rational v0.4.2
      Updating object v0.36.7 -> v0.37.3
      Updating once_cell_polyfill v1.70.1 -> v1.70.2
      Updating openssl v0.10.73 -> v0.10.75
      Updating openssl-sys v0.9.109 -> v0.9.111
      Removing overload v0.1.1
      Updating owo-colors v4.2.1 -> v4.2.3
        Adding page_size v0.6.0
      Updating parking_lot v0.12.4 -> v0.12.5
      Updating parking_lot_core v0.9.11 -> v0.9.12
      Updating pem v3.0.5 -> v3.0.6
      Updating percent-encoding v2.3.1 -> v2.3.2
        Adding pin-project v1.1.10
        Adding pin-project-internal v1.1.10
      Updating polling v3.8.0 -> v3.11.0
      Updating potential_utf v0.1.2 -> v0.1.4
      Updating proc-macro-crate v3.3.0 -> v3.4.0
      Updating proc-macro2 v1.0.95 -> v1.0.103
        Adding prost v0.14.2
        Adding prost-derive v0.14.2
        Adding prost-types v0.14.2
      Updating quote v1.0.40 -> v1.0.42
      Updating r-efi v5.2.0 -> v5.3.0
      Updating r2d2_sqlite v0.29.0 -> v0.31.0
      Updating rand v0.9.1 -> v0.9.2
      Updating rayon v1.10.0 -> v1.11.0
      Updating rayon-core v1.12.1 -> v1.13.0
      Removing redox_syscall v0.3.5
      Removing redox_syscall v0.5.12
        Adding redox_syscall v0.5.18
        Adding ref-cast v1.0.25
        Adding ref-cast-impl v1.0.25
      Updating regex v1.11.1 -> v1.12.2
      Updating regex-automata v0.4.9 -> v0.4.13
      Updating regex-syntax v0.8.5 -> v0.8.8
      Updating reqwest v0.12.20 -> v0.12.24
        Adding rstest v0.26.1
        Adding rstest_macros v0.26.1
      Updating rusqlite v0.36.0 -> v0.37.0
      Updating rust_decimal v1.37.1 -> v1.39.0
      Updating rustc-demangle v0.1.25 -> v0.1.26
      Updating rustix v1.0.7 -> v1.1.2
      Updating rustls v0.23.27 -> v0.23.35
      Updating rustls-native-certs v0.8.1 -> v0.8.2
      Updating rustls-pki-types v1.12.0 -> v1.13.1
      Updating rustls-webpki v0.103.3 -> v0.103.8
      Updating rustversion v1.0.21 -> v1.0.22
      Updating schannel v0.1.27 -> v0.1.28
        Adding schemars v0.9.0
        Adding schemars v1.1.0
      Updating security-framework v3.2.0 -> v3.5.1
      Updating security-framework-sys v2.14.0 -> v2.15.0
      Updating semver v1.0.26 -> v1.0.27
      Updating serde v1.0.219 -> v1.0.228
      Updating serde_bytes v0.11.17 -> v0.11.19
        Adding serde_core v1.0.228
      Updating serde_derive v1.0.219 -> v1.0.228
      Updating serde_html_form v0.2.7 -> v0.2.8
      Updating serde_json v1.0.140 -> v1.0.145
      Updating serde_path_to_error v0.1.17 -> v0.1.20
        Adding serde_spanned v1.0.3
      Updating serde_with v3.12.0 -> v3.16.1
      Updating serde_with_macros v3.12.0 -> v3.16.1
      Updating signal-hook-registry v1.4.5 -> v1.4.7
        Adding simd-adler32 v0.3.7
      Updating slab v0.4.9 -> v0.4.11
        Adding socket2 v0.6.1
      Updating stable_deref_trait v1.2.0 -> v1.2.1
      Updating syn v2.0.102 -> v2.0.111
      Updating tempfile v3.20.0 -> v3.23.0
      Updating terminal_size v0.4.2 -> v0.4.3
      Updating testcontainers v0.24.0 -> v0.26.0
      Updating thiserror v2.0.12 -> v2.0.17
      Updating thiserror-impl v2.0.12 -> v2.0.17
      Updating thread_local v1.1.8 -> v1.1.9
      Updating time v0.3.41 -> v0.3.44
      Updating time-core v0.1.4 -> v0.1.6
      Updating time-macros v0.2.22 -> v0.2.24
      Updating tinystr v0.8.1 -> v0.8.2
      Updating tinyvec v1.9.0 -> v1.10.0
      Updating tokio v1.45.1 -> v1.48.0
      Updating tokio-macros v2.5.0 -> v2.6.0
      Updating tokio-rustls v0.26.2 -> v0.26.4
      Removing tokio-tar v0.3.1
      Updating tokio-util v0.7.15 -> v0.7.17
        Adding toml v0.9.8
        Adding toml_datetime v0.7.3
        Adding toml_edit v0.23.7
        Adding toml_parser v1.0.4
        Adding toml_writer v1.0.4
        Adding tonic v0.14.2
        Adding tonic-prost v0.14.2
      Updating tower-http v0.6.6 -> v0.6.7
      Updating tracing v0.1.41 -> v0.1.43
      Updating tracing-attributes v0.1.29 -> v0.1.31
      Updating tracing-core v0.1.34 -> v0.1.35
      Updating tracing-subscriber v0.3.19 -> v0.3.22
      Updating typenum v1.18.0 -> v1.19.0
      Updating unicode-ident v1.0.18 -> v1.0.22
      Updating unicode-width v0.2.1 -> v0.2.2
        Adding ureq v3.1.4
        Adding ureq-proto v0.5.3
      Updating url v2.5.4 -> v2.5.7
        Adding utf-8 v0.7.6
      Updating uuid v1.17.0 -> v1.18.1
      Updating value-bag v1.11.1 -> v1.12.0
      Removing wasi v0.14.2+wasi-0.2.4
        Adding wasip2 v1.0.1+wasi-0.2.4
      Updating wasm-bindgen v0.2.100 -> v0.2.106
      Removing wasm-bindgen-backend v0.2.100
      Updating wasm-bindgen-futures v0.4.50 -> v0.4.56
      Updating wasm-bindgen-macro v0.2.100 -> v0.2.106
      Updating wasm-bindgen-macro-support v0.2.100 -> v0.2.106
      Updating wasm-bindgen-shared v0.2.100 -> v0.2.106
      Updating web-sys v0.3.77 -> v0.3.83
        Adding web-time v1.1.0
        Adding webpki-roots v1.0.4
      Updating winapi-util v0.1.9 -> v0.1.11
      Updating windows-core v0.61.2 -> v0.62.2
      Updating windows-implement v0.60.0 -> v0.60.2
      Updating windows-interface v0.59.1 -> v0.59.3
      Updating windows-link v0.1.1 -> v0.2.1
      Updating windows-registry v0.5.2 -> v0.6.1
      Updating windows-result v0.3.4 -> v0.4.1
      Updating windows-strings v0.4.2 -> v0.5.1
        Adding windows-sys v0.60.2
        Adding windows-sys v0.61.2
      Updating windows-targets v0.53.0 -> v0.53.5
      Updating windows_aarch64_gnullvm v0.53.0 -> v0.53.1
      Updating windows_aarch64_msvc v0.53.0 -> v0.53.1
      Updating windows_i686_gnu v0.53.0 -> v0.53.1
      Updating windows_i686_gnullvm v0.53.0 -> v0.53.1
      Updating windows_i686_msvc v0.53.0 -> v0.53.1
      Updating windows_x86_64_gnu v0.53.0 -> v0.53.1
      Updating windows_x86_64_gnullvm v0.53.0 -> v0.53.1
      Updating windows_x86_64_msvc v0.53.0 -> v0.53.1
      Updating winnow v0.7.11 -> v0.7.14
        Adding wit-bindgen v0.46.0
      Removing wit-bindgen-rt v0.39.0
      Updating writeable v0.6.1 -> v0.6.2
      Updating xattr v1.5.0 -> v1.6.1
      Updating yoke v0.8.0 -> v0.8.1
      Updating yoke-derive v0.8.0 -> v0.8.1
      Updating zerocopy v0.8.25 -> v0.8.31
      Updating zerocopy-derive v0.8.25 -> v0.8.31
      Updating zeroize v1.8.1 -> v1.8.2
      Updating zerotrie v0.2.2 -> v0.2.3
      Updating zerovec v0.11.2 -> v0.11.5
      Updating zerovec-derive v0.11.1 -> v0.11.2
      Updating zstd-sys v2.0.15+zstd.1.5.7 -> v2.0.16+zstd.1.5.7
  note: pass `--verbose` to see 6 unchanged dependencies behind latest
  ```

ACKs for top commit:
  josecelano:
    ACK 11721dc

Tree-SHA512: 2605f632b98aab39bcbcc8cbf322060d84f89967aef88d65194762596b0fe10e54ba8e38e406076854b4acf295bcd074690bd0a559479cf903090f68d309274f

Author: josecelano

Cargo.lock

@@ -29,6 +29,7 @@ pub async fn run(udp_trackers: Vec<Url>, timeout: Duration) -> Vec<Result<Checks
 
     tracing::debug!("UDP trackers ...");
 
+    #[allow(clippy::incompatible_msrv)]
     let info_hash = aquatic_udp_protocol::InfoHash(hex!("9c38422213e30bff212b30c360d26f9a02136422")); // DevSkim: ignore DS173237
 
     for remote_url in udp_trackers {

console/tracker-client/src/console/clients/checker/checks/udp.rs

@@ -86,7 +86,7 @@ impl Query {
         self.params.get_vec(name).map(|pairs| {
             let mut param_values = vec![];
             for pair in pairs {
-                param_values.push(pair.value.to_string());
+                param_values.push(pair.value.clone());
             }
             param_values
         })

packages/http-protocol/src/v1/query.rs

@@ -389,15 +389,11 @@ mod tests {
             let remote_client_ip = IpAddr::V4(Ipv4Addr::new(126, 0, 0, 1));
 
             let server_service_binding_clone = server_service_binding.clone();
-            let peer_copy = peer;
 
             let mut http_stats_event_sender_mock = MockHttpStatsEventSender::new();
             http_stats_event_sender_mock
                 .expect_send()
                 .with(predicate::function(move |event| {
-                    let mut announced_peer = peer_copy;
-                    announced_peer.peer_addr = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(126, 0, 0, 1)), 8080);
-
                     let mut announcement = peer;
                     announcement.peer_addr = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(126, 0, 0, 1)), 8080);
 
@@ -462,15 +458,11 @@ mod tests {
             let remote_client_ip = IpAddr::V4(Ipv4Addr::LOCALHOST);
 
             let server_service_binding_clone = server_service_binding.clone();
-            let peer_copy = peer;
 
             let mut http_stats_event_sender_mock = MockHttpStatsEventSender::new();
             http_stats_event_sender_mock
                 .expect_send()
                 .with(predicate::function(move |event| {
-                    let mut announced_peer = peer_copy;
-                    announced_peer.peer_addr = SocketAddr::new(IpAddr::V4(Ipv4Addr::LOCALHOST), 8080);
-
                     let mut peer_announcement = peer;
                     peer_announcement.peer_addr = SocketAddr::new(
                         IpAddr::V6(Ipv6Addr::new(0x6969, 0x6969, 0x6969, 0x6969, 0x6969, 0x6969, 0x6969, 0x6969)),

packages/http-tracker-core/src/services/announce.rs

@@ -496,7 +496,7 @@ mod tests {
         swarm.upsert_peer(peer.into()).await;
 
         // Remove peers not updated since one second before inserting the peer.
-        swarm.remove_inactive(last_update_time - one_second).await;
+        swarm.remove_inactive(last_update_time.checked_sub(one_second).unwrap()).await;
 
         assert_eq!(swarm.len(), 1);
     }

packages/swarm-coordination-registry/src/swarm/coordinator.rs

@@ -265,7 +265,7 @@ mod tests {
             peer_list.upsert(peer.into());
 
             // Remove peers not updated since one second before inserting the peer.
-            peer_list.remove_inactive_peers(last_update_time - one_second);
+            peer_list.remove_inactive_peers(last_update_time.checked_sub(one_second).unwrap());
 
             assert_eq!(peer_list.len(), 1);
         }

packages/torrent-repository-benchmarking/src/entry/peer_list.rs

@@ -105,7 +105,7 @@ pub async fn get_torrent_info(
 
     let peers = torrent_entry.lock().await.peers(None);
 
-    let peers = Some(peers.iter().map(|peer| (**peer)).collect());
+    let peers = Some(peers.iter().map(|peer| **peer).collect());
 
     Some(Info {
         info_hash: *info_hash,

packages/tracker-core/src/torrent/services.rs

@@ -164,7 +164,7 @@ impl From<Error> for ErrorKind {
                 },
                 UdpScrapeError::TrackerCoreWhitelistError { source } => Self::Whitelist(source.to_string()),
             },
-            Error::Internal { location: _, message } => Self::InternalServer(message.to_string()),
+            Error::Internal { location: _, message } => Self::InternalServer(message.clone()),
             Error::AuthRequired { location } => Self::TrackerAuthentication(location.to_string()),
         }
     }

packages/udp-tracker-server/src/event.rs

@@ -251,7 +251,7 @@ mod receiving_an_announce_request {
             let transaction_id = tx_id.0.to_string();
 
             assert!(
-                logs_contains_a_line_with(&["ERROR", "UDP TRACKER", &transaction_id.to_string()]),
+                logs_contains_a_line_with(&["ERROR", "UDP TRACKER", &transaction_id]),
                 "Expected logs to contain: ERROR ... UDP TRACKER ... transaction_id={transaction_id}"
             );
         }

packages/udp-tracker-server/tests/server/contract.rs

@@ -82,7 +82,7 @@ impl Docker {
         let mut port_args: Vec<String> = vec![];
         for port in &options.ports {
             port_args.push("--publish".to_string());
-            port_args.push(port.to_string());
+            port_args.push(port.clone());
         }
 
         let args = [initial_args, env_var_args, port_args, [image.to_string()].to_vec()].concat();